chore: Merge branch dev to main

[github-actions]

This pull request will Merge branch dev to main.

Before merging this PR

• Pull translations from Crowdin

[0xrxL]

@LisoUseInAIKyrios I have a question about litho filtering:

I noticed that filtering required two parameters: a string and a stringbuilder, in this patch point:

val invokeFilterInstructions = """
  invoke-static { v$identifierRegister, v$stringBuilderRegister }, $EXTENSION_CLASS_DESCRIPTOR->filter(Ljava/lang/String;Ljava/lang/StringBuilder;)Z
  move-result v$freeRegister
  if-eqz v$freeRegister, :unfiltered
"""

The first parameter (the string) return only the template name, but this is already printed in the second parameter (the stringbuilder).

Maybe the first parameter can be removed from the patch?

[oSumAtrIX]

Sometimes the identified is present only in the first parameter, and vice versa

[LisoUseInAIKyrios]

Checking the path instead of the identifier (template name) requires checking if the match is the start of the path, when the identifier is always the start. A small point but still slightly relevant.

The identifier appears only once but appears in every path subcomponent, which means the identifier needs only one callback instead of calling back for every sub component of that template:

Searching ID: video_lockup_with_attachment.eml|f87337c95957173d Path: video_lockup_with_attachment.eml|f87337c95957173d|CellType|

Searching ID: null Path: video_lockup_with_attachment.eml|f87337c95957173d|CellType|ContainerType|

Searching ID: null Path: video_lockup_with_attachment.eml|f87337c95957173d|CellType|video_lockup.eml|ecaa48d6265f5006|ContainerType|

So yeah it could be removed, but I think for performance it's better if the identifier remains exposed for filtering.

[0xrxL]

Sometimes the identified is present only in the first parameter, and vice versa

Yeah, I remember that. It happened with some ads in past, but these ads are now gone due to twice (or more) layout changes (in fact both string and stringbuilder outputs are now aligned).

[LisoUseInAIKyrios]

Anything left to do before merging this?

[0xrxL]

Anything left to do before merging this?

19.45 support, to fix miniplayer stock bugs. 👍

[LisoUseInAIKyrios]

@oSumAtrIX Anything todo before merging?

[LisoUseInAIKyrios]

Try clearing Manager data. Files are saving correctly for me: youtube-revanced_v19.43.41-patches_v5.1.0.apk

[MarcaDian]

I think it was a network delay when the patch file was downloaded but the manager didn't show the version yet, I've had this happen before.
Maybe this problem is more related to the manager