Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube): Remember Playback Speed changes behaves different with playlists and opening videos in the same player #52

Closed
3 tasks done
Randomuser457 opened this issue Dec 1, 2023 · 7 comments · Fixed by #3914 or #3909
Labels
Bug report Something isn't working

Comments

@Randomuser457
Copy link

Bug description

Disabling "Remember Playback Speed changes" from revanced >video
dosent work on 1.0x.
if its switched off and i change playback speed to anything, it'll remember it in next video.
but if default playback speed is anything other than 1.0x , and i change playback speed in video, it'll go back to default speed in next video but only if default speed is not set to 1.0x.

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Randomuser457 Randomuser457 added the Bug report Something isn't working label Dec 1, 2023
@LisoUseInAIKyrios
Copy link
Contributor

Your instructions are a bit confusing.

List the exact steps to reproduce the issue.

@Randomuser457
Copy link
Author

Randomuser457 commented Dec 1, 2023

  1. revanced>video>default playback speed> set to 1.0x and and turned off "Remember Playback Speed Changes".

Now if i open any video and from top right corner i change playback speed to anything e.g. 1.5x and i switch to another video, that video will start with 1.5 playback speed even when i have turned off that setting.

but

  1. when i have set revanced>video>default playback speed> anything other than 1.0x lets say 1.25x and do the same process above of switching to 1.5x from inside the video and then open another video, it'll start with 1.25x.

so the bug is in 1.0x speed.
I've sent video in discord server support section and my discord tag is (monank)

@oSumAtrIX
Copy link
Member

From my tests, the override speed hook is not being called when the speed is set to 1.0

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Dec 1, 2023

This is the behavior of stock YouTube.

Try with stock YouTube and you'll see:

Open a video, change the speed, then open a new video from inside the video player (ie: open a video from the suggested videos below the currently playing video), YouTube will retain the existing playback speed until you close the player.

But if you close the video player, then open a new video, the playback speed will be back to 1.0

The playback speed patch is altering this behavior, but only if the speed on video load is not 1.0x.

Some ways to resolve this would be picking one of:

  1. set the speed back back to 1.0x for this situation. This would alter the stock YouTube behavior, for better or worse, and playlists would be affected the most.
  2. do not reset the playback speed to the default, if the playback speed is not 1.0x when the video loads (would match stock YouTube behavior, but may not be what some users want)
  3. Make no changes, and accept the existing patch behavior as-is.

@Randomuser457
Copy link
Author

yea looks like its issue of original YouTube.

So can it be fixed in revanced or it'll stay like this and can't do anything?

@oSumAtrIX
Copy link
Member

There's three options in the previous comment

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title Disabling "Remember Playback Speed changes" dosent work on 1.0x bug(YouTube): Disabling "Remember Playback Speed changes" does not work on 1.0x Dec 25, 2023
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube): Disabling "Remember Playback Speed changes" does not work on 1.0x bug(YouTube): Remember Playback Speed changes behaves different with playlists Aug 12, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube): Remember Playback Speed changes behaves different with playlists bug(YouTube): Remember Playback Speed changes behaves different with playlists and opening videos in the same player Aug 12, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Nov 14, 2024

Another option that can fix this, is to add an "auto" entry to the default playback speed setting.

Where "auto" would act the same as unpatched YouTube, and a changd of video speed is retained across multiple videos until the player is closed.

Then if a default speed of 1.0x is used, the speed will always be reset to 1.0x on every new video load. This behavior would be consistent with the behavior of using a non 1.0x default speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
3 participants