-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube): Remember Playback Speed changes behaves different with playlists and opening videos in the same player #52
Comments
Your instructions are a bit confusing. List the exact steps to reproduce the issue. |
Now if i open any video and from top right corner i change playback speed to anything e.g. 1.5x and i switch to another video, that video will start with 1.5 playback speed even when i have turned off that setting. but
so the bug is in 1.0x speed. |
From my tests, the override speed hook is not being called when the speed is set to 1.0 |
This is the behavior of stock YouTube. Try with stock YouTube and you'll see: Open a video, change the speed, then open a new video from inside the video player (ie: open a video from the suggested videos below the currently playing video), YouTube will retain the existing playback speed until you close the player. But if you close the video player, then open a new video, the playback speed will be back to 1.0 The playback speed patch is altering this behavior, but only if the speed on video load is not 1.0x. Some ways to resolve this would be picking one of:
|
yea looks like its issue of original YouTube. So can it be fixed in revanced or it'll stay like this and can't do anything? |
There's three options in the previous comment |
Another option that can fix this, is to add an "auto" entry to the default playback speed setting. Where "auto" would act the same as unpatched YouTube, and a changd of video speed is retained across multiple videos until the player is closed. Then if a default speed of 1.0x is used, the speed will always be reset to 1.0x on every new video load. This behavior would be consistent with the behavior of using a non 1.0x default speed. |
Bug description
Disabling "Remember Playback Speed changes" from revanced >video
dosent work on 1.0x.
if its switched off and i change playback speed to anything, it'll remember it in next video.
but if default playback speed is anything other than 1.0x , and i change playback speed in video, it'll go back to default speed in next video but only if default speed is not set to 1.0x.
Error logs
No response
Solution
No response
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: