feat(YouTube): Add an option to disable the popup regarding whitelisting of ReVanced-Gms

[d-e-n-n-i-s-t]

Feature description

I suggest adding a toggle somewhere deep in the ReVanced settings that enables a user to disable this annoying popup that was added in the last update:

Default behaivor can stay the same as it is now. It's just about adding a possibility to somehow get rid of this popup.

Motivation

The reason for adding a toggle like that is that ReVanced-Gms doesn't actually need to be whitelisted, and therefore the user shouldn't be annoyed with a popup that prompts him to do so, every time the user opens the app.
The patched YouTube app in general works fine with ReVanced-Gms even being set to restricted (more restricted than the default, optimized), and even background play works up to an hour (just haven't tested it longer).
Users not wanting notifications don't need ReVanced-Gms to maintain a connection to Google for GCM.
Apps not absolutely needing to be whitelisted should not be forced to be whitelisted - it's just a matter of principle.

I get that it can resolve issues for some user, but realistically, what is to be said against a toggle that preserves the current behavior by default? Then, only users that know what they get into would actually disable the popup.

Cheers

Acknowledgements

• This issue is not a duplicate of an existing feature request.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[oSumAtrIX]

Whats the practical reason of disabling whitelist? Because if it is about battery, GmsCore does not consume any considerable amount.

[d-e-n-n-i-s-t]

Whats the practical reason of disabling whitelist? Because if it is about battery, GmsCore does not consume any considerable amount.

The question should be the other way around; Whats the practical reason for enabling the whitelisting of ReVanced-Gms in the mentioned scenario? You know, its not that way by default.

To quote myself: "Apps not absolutely needing to be whitelisted should not be forced to be whitelisted - it's just a matter of principle."

[oSumAtrIX]

The practical reason is to prevent the app from malfunctioning in the background, even if in your limited experience, it hasn't been a problem. This goes as explained in https://github.com/microg/GmsCore/wiki/Installation. Back to my question.

[LisoUseInAIKyrios]

@d-e-n-n-i-s-t did you search before posting? This has been discussed too many times.

#2973

#2997

#3013

#3041

#3049

Battery optimization must be turned off for most devices, otherwise YT can randomly shutdown without any explanation.

If YT works for you without battery optimization turned off, that means MicroG is already not receiving battery optimizations and "turning off optimizations" effectively does nothing.

Everytime someone makes this same complaint, data is asked to show there is a noticable difference in battery usage with and without whitelisting. But nobody ever provides said data, because the data shows less than 1% battery and "turning off optimizations" will not make any difference.

On my device I see MicroG uses 0.1% battery usage despite using YT a lot and battery optimizations are turned off for MicroG.

You can always root your device, and never be bothered with MicroG ever again.

[d-e-n-n-i-s-t]

The practical reason is to prevent the app from malfunctioning in the background, even if in your limited experience, it hasn't been a problem. This goes as explained in https://github.com/microg/GmsCore/wiki/Installation. Back to my question.

The wiki states "as it is required to keep a stable background connection". As I mentioned, for some scenarios, it's NOT required.

I already answered your question in the main post and in my first answer - it's a matter of principle. If it doesn't need to be whitelisted, one shouldn't be forced to whitelist it. Its not that complicated.

Its also not just a "limited experience". I've been using it without a single problem since its release, also for years with Vanced MicroG before, while it was being set to restricted. If there were any problems in the aforementioned scenario (no notifications needed), I would think that I must have encountered it, which I didnt.

[oSumAtrIX]

The wiki states "as it is required to keep a stable background connection". As I mentioned, for some scenarios, it's NOT required.

This is half of the story. If the app stops so does apps that depend on it.

I have explained that it is a necessity so arguing about principles here won't work.

[d-e-n-n-i-s-t]

@d-e-n-n-i-s-t did you search before posting? This has been discussed too many times.

#2973

#2997

#3013

#3041

#3049

Battery optimization must be turned off for most devices, otherwise YT can randomly shutdown without any explanation.

If YT works for you without battery optimization turned off, that means MicroG is already not receiving battery optimizations and "turning off optimizations" effectively does nothing.

Everytime someone makes this same complaint, data is asked to show there is a noticable difference in battery usage with and without whitelisting. But nobody ever provides said data, because the data shows less than 1% battery and "turning off optimizations" will not make any difference.

On my device I see MicroG uses 0.1% battery usage despite using YT a lot and battery optimizations are turned off for MicroG.

You can always root your device, and never be bothered with MicroG ever again.

I searched, but searched for "popup" and "whitelist". And as far as I understand, those issues don't talk about the popup because at the point of the opening those issues, that popup wasn't even introduced yet.

[LisoUseInAIKyrios]

I searched, but searched for "popup" and "whitelist". And as far as I understand, those issues don't talk about the popup because at the point iof opening the issues, that popup wasn't even introduced yet.

Every issue I posted is identical to what you're asking here. That's not including the 2 or 3 issues others created in the ReVanced MicroG repo as well.

[d-e-n-n-i-s-t]

The wiki states "as it is required to keep a stable background connection". As I mentioned, for some scenarios, it's NOT required.

This is half of the story. If the app stops so does apps that depend on it.

I have explained that it is a necessity so arguing about principles here won't work.

No, you haven't explained it, you just stated it. There is no evidence it really is needed in that scenario, and there can't be, because it isn't. Even the wiki doesn't state it, even though you mentioned it.
But there's no coming through to you, maybe some other dev reads it.

[oSumAtrIX]

Since you decided to get hung up on me "stating" instead of "explaining" it, ill make this short.

I'll be happy to add an option if there's a real reason to, but as far as I am concerned, if the app is not excluded from battery optimizations, it can and does exit in background. For that mere reason, unless there's a weighting argument against having it not excluded from battery optimizations, I'll close the issue.

[akashpal-21]

Really unfortunate that the devs would shove this down our throat and won't give us an option. It works perfectly fine with restricted battery usage.
Let us take the risk of exiting - some of us don't use the app for extended periods.

Seems unlikely that reason and rationale would trickle down to the arrogant dev, for now we are left with a authoritarian decision shoved to us -- for our benefit.

[oSumAtrIX]

I won't repeat what I said, feel free to provide the information I asked above or don't bother at all

[akashpal-21]

There is no information to provide. If we do Optimised it would still run in the background nevertheless. It consumes less than <1% in 24h.

But I DO NOT WANT TO RUN IT I WANT IT RESTRICTED. I WANT IT TO CLOSE AS SOON AS I CLOSE YOUTUBE.

It's not about battery. It's about control over things I have in my phone.

[oSumAtrIX]

Enabling optimization doesn't close the app in the background when you close YouTube. I am not sure why you are arguing when you don't even know that and I won't continue for that reason

[oSumAtrIX]

Previous comment that was deleted:

That is the point. I want it to close. I want it to exit. I do not want it running in the background.

I understand the implications 100%. You won't continue because you have made a decision and isn't ready to listen to anyone. That is your call.

Have a good day

That's absolutely besides the topic. What you want to close and not is not related to battery optimization, classic case of dunning Kruger effect.

Locking because multiple people rudly complaining either are completely besides the point or refuse to provide any proper reason to not disable battery optimization.

[LisoUseInAIKyrios]

I will mention this here because some naive users see YouTube using a lot of battery and think it's caused by MicroG power optimizations:

Changing battery optimization settings for MicroG will not change the battery usage of ReVanced YouTube.

If anyone wants to reduce battery usage of YouTube they can:

1. Turn off ambient mode (the background color glow around videos). This alone can make a big difference for both ReVanced and stock YouTube.
2. If you don't care about new video push notifications (or you don't have any video notifications turned on), then turn off device registration and cloud messaging in MicroG.
3. Add ReVanced YouTube to restricted battery usage (restrict YouTube, not MicroG). On some devices this may prevent push notifications or interfere with PiP background playback, but for most devices this works without issue and it slightly improves battery usage.
4. Do not set a default video resolution in ReVanced settings and instead use the built in YouTube video quality setting (ie: high/low quality). This should be obvious but users seem to forget that always selecting 1080p or 1440p uses more battery than the default 480/720/1080 stock YouTube gives.

And if someone does not want to make any of these changes, then at least be aware.