fix(YouTube - GmsCore support): Prompt to disable battery optimizations, if not done already #2958

LisoUseInAIKyrios · 2024-03-31T09:57:33Z

If GmsCore is not whitelisted from device power optimizations:

Show a dialog explaining why they need to turn off power optimizations
Open the prompt to turn off optimizations

This is much simpler than opening a website explaining more changes.

If GmsCore is not running in the background on app launch, then the dontkillmyapp.com is still opened, as that condition needs instructions specific to the users device and operating system (a simple exclude from battery optimizations likely will not fix it).

Integration changes

oSumAtrIX · 2024-03-31T12:59:39Z

GmsCore is the new official name of MicroG. I don't think it makes sense to mislabel it. If at all, I'd call it MicroG GmsCore.

…website.

LisoUseInAIKyrios · 2024-04-01T05:06:23Z

It now opens opens the device prompt to turn off battery optimizations.

src/main/resources/addresources/values/strings.xml

Co-authored-by: oSumAtrIX <[email protected]>

LisoUseInAIKyrios · 2024-04-03T10:45:03Z

I think this might be good to go

…ialog_text # Conflicts: # src/main/resources/addresources/values/strings.xml

src/main/kotlin/app/revanced/patches/music/misc/gms/GmsCoreSupportPatch.kt

.../kotlin/app/revanced/patches/music/misc/gms/fingerprints/MusicActivityOnCreateFingerprint.kt

src/main/resources/addresources/values/strings.xml

Co-authored-by: oSumAtrIX <[email protected]>

# Conflicts: # src/main/resources/addresources/values/strings.xml

## [4.6.1-dev.3](v4.6.1-dev.2...v4.6.1-dev.3) (2024-04-06) ### Bug Fixes * **YouTube - GmsCore support:** Prompt to disable battery optimizations, if not done already ([#2958](#2958)) ([82acb84](82acb84))

# [4.7.0](v4.6.0...v4.7.0) (2024-04-21) ### Bug Fixes * **Tumblr - Fix old versions:** Improve reliability by removing remnances of Tumblr Live ([#2988](#2988)) ([897b4db](897b4db)) * **YouTube - GmsCore support:** Prompt to disable battery optimizations, if not done already ([#2958](#2958)) ([82acb84](82acb84)) * **YouTube - Hide ads:** rename `Hide paid content` to `Hide paid promotion label` ([#3026](#3026)) ([17e4ac9](17e4ac9)) * **YouTube - Hide load more button:** Include patch with `Hide layout components`, and hide button only in search feed ([#2959](#2959)) ([b007e8e](b007e8e)) * **YouTube - Hide Shorts components:** Correctly hide Shorts if navigation tab is changed using device back button ([#3007](#3007)) ([e5848e9](e5848e9)) * **YouTube - Player flyout menu:** Add hide Lock screen menu ([#2985](#2985)) ([308de4a](308de4a)) * **YouTube - Spoof device dimensions:** Warn about potential performance issues ([#3039](#3039)) ([9d6f305](9d6f305)) * **YouTube Music - Remove upgrade button:** Fix compatibility with latest versions ([#3045](#3045)) ([80de996](80de996)) ### Features * Add `Hex` patch ([#3034](#3034)) ([3c95aac](3c95aac)) * **Amazon:** Add `Always allow deep-linking` patch ([#3000](#3000)) ([a92b7fb](a92b7fb)) * **Strava - Unlock subscription:** Remove compatible version constraint ([80a5599](80a5599)) * **Twitter:** Add `Sanitize sharing links` patch ([#3003](#3003)) ([186b887](186b887)) * **YouTube - Hide layout components:** Add option to hide horizontal shelves ([#2951](#2951)) ([9ae0650](9ae0650)) * **YouTube - Hide layout components:** Hide playables ([8423515](8423515)) * **YouTube - Hide Shorts components:** Hide `Shop`, `Location` and `Save sound to playlist` buttons ([#3018](#3018)) ([5210ac4](5210ac4)) * **YouTube - Hide Shorts components:** Hide tagged products, hide search suggestions ([#3019](#3019)) ([e0d2fe5](e0d2fe5)) * **YouTube - Swipe controls:** Save and restore brightness and add auto-brightness toggle ([#2996](#2996)) ([f6c3bc4](f6c3bc4)) * **YouTube:** Add 'About' preference to settings menu ([#2981](#2981)) ([5abf894](5abf894)) * **YouTube:** Match overlay icons style to YouTube ([#3023](#3023)) ([6849393](6849393)) * **YouTube:** Support version `19.09.38`, `19.10.39` and `19.11.43` ([#2971](#2971)) ([730f3e3](730f3e3)) * **YT Music - Hide 'Get Music Premium' label:** Remove occurences of label in settings ([#3046](#3046)) ([10e170a](10e170a))

# [4.7.0](v4.6.0...v4.7.0) (2024-04-21) ### Bug Fixes * **Tumblr - Fix old versions:** Improve reliability by removing remnances of Tumblr Live ([ReVanced#2988](https://github.com/E85Addict/revanced-patches/issues/2988)) ([897b4db](897b4db)) * **YouTube - GmsCore support:** Prompt to disable battery optimizations, if not done already ([ReVanced#2958](https://github.com/E85Addict/revanced-patches/issues/2958)) ([82acb84](82acb84)) * **YouTube - Hide ads:** rename `Hide paid content` to `Hide paid promotion label` ([ReVanced#3026](https://github.com/E85Addict/revanced-patches/issues/3026)) ([17e4ac9](17e4ac9)) * **YouTube - Hide load more button:** Include patch with `Hide layout components`, and hide button only in search feed ([ReVanced#2959](https://github.com/E85Addict/revanced-patches/issues/2959)) ([b007e8e](b007e8e)) * **YouTube - Hide Shorts components:** Correctly hide Shorts if navigation tab is changed using device back button ([ReVanced#3007](https://github.com/E85Addict/revanced-patches/issues/3007)) ([e5848e9](e5848e9)) * **YouTube - Player flyout menu:** Add hide Lock screen menu ([ReVanced#2985](https://github.com/E85Addict/revanced-patches/issues/2985)) ([308de4a](308de4a)) * **YouTube - Spoof device dimensions:** Warn about potential performance issues ([ReVanced#3039](https://github.com/E85Addict/revanced-patches/issues/3039)) ([9d6f305](9d6f305)) * **YouTube Music - Remove upgrade button:** Fix compatibility with latest versions ([ReVanced#3045](https://github.com/E85Addict/revanced-patches/issues/3045)) ([80de996](80de996)) ### Features * Add `Hex` patch ([ReVanced#3034](https://github.com/E85Addict/revanced-patches/issues/3034)) ([3c95aac](3c95aac)) * **Amazon:** Add `Always allow deep-linking` patch ([ReVanced#3000](https://github.com/E85Addict/revanced-patches/issues/3000)) ([a92b7fb](a92b7fb)) * **Strava - Unlock subscription:** Remove compatible version constraint ([80a5599](80a5599)) * **Twitter:** Add `Sanitize sharing links` patch ([ReVanced#3003](https://github.com/E85Addict/revanced-patches/issues/3003)) ([186b887](186b887)) * **YouTube - Hide layout components:** Add option to hide horizontal shelves ([ReVanced#2951](https://github.com/E85Addict/revanced-patches/issues/2951)) ([9ae0650](9ae0650)) * **YouTube - Hide layout components:** Hide playables ([8423515](8423515)) * **YouTube - Hide Shorts components:** Hide `Shop`, `Location` and `Save sound to playlist` buttons ([ReVanced#3018](https://github.com/E85Addict/revanced-patches/issues/3018)) ([5210ac4](5210ac4)) * **YouTube - Hide Shorts components:** Hide tagged products, hide search suggestions ([ReVanced#3019](https://github.com/E85Addict/revanced-patches/issues/3019)) ([e0d2fe5](e0d2fe5)) * **YouTube - Swipe controls:** Save and restore brightness and add auto-brightness toggle ([ReVanced#2996](https://github.com/E85Addict/revanced-patches/issues/2996)) ([f6c3bc4](f6c3bc4)) * **YouTube:** Add 'About' preference to settings menu ([ReVanced#2981](https://github.com/E85Addict/revanced-patches/issues/2981)) ([5abf894](5abf894)) * **YouTube:** Match overlay icons style to YouTube ([ReVanced#3023](https://github.com/E85Addict/revanced-patches/issues/3023)) ([6849393](6849393)) * **YouTube:** Support version `19.09.38`, `19.10.39` and `19.11.43` ([ReVanced#2971](https://github.com/E85Addict/revanced-patches/issues/2971)) ([730f3e3](730f3e3)) * **YT Music - Hide 'Get Music Premium' label:** Remove occurences of label in settings ([ReVanced#3046](https://github.com/E85Addict/revanced-patches/issues/3046)) ([10e170a](10e170a)) ### Performance Improvements * Personal Logo && Add upstream sync ([7f40bcb](7f40bcb))

d-e-n-n-i-s-t · 2024-04-22T00:06:01Z

Why does this have to keep annoying users that don't need to whitelist MicroG GmsCore? I don't use background playback/notifications, so why do I have to dismiss this annoying popup everytime I open ReVanced YouTube? Atleast create an option to disable this popup.

oSumAtrIX · 2024-04-22T00:13:58Z

GmsCore must run in the background for the app to work correctly, not just for notifications.

d-e-n-n-i-s-t · 2024-04-22T00:26:09Z

Not true from my experience, I never had any issues with it's Battery Optimization Setting being on restricted (worse than default, "optimized"). Weirdly, even background playback works for me up to an hour (haven't used it longer yet)
Furthermore, it actually can run in the background without being set to unrestricted. Afaik, that settings mostly affects behavior on Android Doze. It can still run in the background when using the phone/ReVanced YouTube.

oSumAtrIX · 2024-04-22T00:30:35Z

If it runs anyways in the background you have no reason to worry about setting it to unrestricted. Once you can provide evidence on setting the option to unrestricted being problematic we can reconsider.

d-e-n-n-i-s-t · 2024-04-22T00:37:47Z

Yeah, Im not doing that for anyone to "reconsider" - its probably not possible to even provide that evidence. It's a matter of principle; only apps that absolutely need it, should be set to unrestricted - it doesn't need to run in idle sleep.
I guess this is where it stays then, just want to annotate that its really inconsiderate to not create a toggle for that popup. Seems to me like it goes against the general pathos of ReVanced, as you can turn off any annoying popups, except this one.

oSumAtrIX · 2024-04-22T01:17:05Z

Yeah, Im not doing that

Feel free to open an issue once you change your mind, as it stands, no change is necessary.

LisoUseInAIKyrios mentioned this pull request Mar 31, 2024

fix(YouTube - GmsCore support): Prompt to disable battery optimizations, if not done already ReVanced/revanced-integrations#601

Merged

fix(YouTube - GmsCore): Improve dialog text instructions

c707804

LisoUseInAIKyrios force-pushed the fix_gmscore_adjust_dialog_text branch from 6b79246 to c707804 Compare March 31, 2024 10:03

LisoUseInAIKyrios force-pushed the fix_gmscore_adjust_dialog_text branch from e6f52a4 to 0172929 Compare March 31, 2024 13:05

fix: Use 'MicroG GmsCore' app name

4db2a9e

LisoUseInAIKyrios force-pushed the fix_gmscore_adjust_dialog_text branch from 0172929 to 4db2a9e Compare March 31, 2024 13:05

LisoUseInAIKyrios added 2 commits April 1, 2024 04:15

fix: Adjust language

acc0d38

fix: Open the GmsCore battery disable optimizations intent and not a …

78368f0

…website.

LisoUseInAIKyrios changed the title ~~fix(YouTube - GmsCore support): Improve dialog text instructions~~ fix(YouTube - GmsCore support): Open device disable battery optimizations menu, if GmsCore is not whitelisted Apr 1, 2024

LisoUseInAIKyrios requested a review from oSumAtrIX April 1, 2024 13:16

oSumAtrIX requested changes Apr 2, 2024

View reviewed changes

src/main/resources/addresources/values/strings.xml Outdated Show resolved Hide resolved

src/main/resources/addresources/values/strings.xml Outdated Show resolved Hide resolved

src/main/resources/addresources/values/strings.xml Outdated Show resolved Hide resolved

oSumAtrIX changed the title ~~fix(YouTube - GmsCore support): Open device disable battery optimizations menu, if GmsCore is not whitelisted~~ fix(YouTube - GmsCore support): Prompt to disable battery optimizations, if not done already Apr 2, 2024

LisoUseInAIKyrios and others added 5 commits April 2, 2024 11:05

Update src/main/resources/addresources/values/strings.xml

67e09a6

Co-authored-by: oSumAtrIX <[email protected]>

Update src/main/resources/addresources/values/strings.xml

812d59c

Co-authored-by: oSumAtrIX <[email protected]>

Update src/main/resources/addresources/values/strings.xml

620c27c

Co-authored-by: oSumAtrIX <[email protected]>

fix: Remove secondary nag

b92fe69

fix: Use activity fingerprint for YT Music, so GmsCore can show a dialog

a7d0cd8

LisoUseInAIKyrios force-pushed the fix_gmscore_adjust_dialog_text branch from 974740d to a7d0cd8 Compare April 3, 2024 10:25

refactor: Remove 'not whitelisted' toast logic that is no longer needed

4db180f

LisoUseInAIKyrios added 2 commits April 4, 2024 14:20

Merge remote-tracking branch 'upstream/dev' into fix_gmscore_adjust_d…

9202bbc

…ialog_text # Conflicts: # src/main/resources/addresources/values/strings.xml

Merge remote-tracking branch 'upstream/dev' into fix_gmscore_adjust_d…

be68699

…ialog_text # Conflicts: # src/main/resources/addresources/values/strings.xml

oSumAtrIX reviewed Apr 4, 2024

View reviewed changes

src/main/kotlin/app/revanced/patches/music/misc/gms/GmsCoreSupportPatch.kt Show resolved Hide resolved

oSumAtrIX reviewed Apr 4, 2024

View reviewed changes

.../kotlin/app/revanced/patches/music/misc/gms/fingerprints/MusicActivityOnCreateFingerprint.kt Show resolved Hide resolved

oSumAtrIX approved these changes Apr 4, 2024

View reviewed changes

oSumAtrIX reviewed Apr 4, 2024

View reviewed changes

src/main/resources/addresources/values/strings.xml Outdated Show resolved Hide resolved

LisoUseInAIKyrios and others added 2 commits April 4, 2024 18:34

Update src/main/resources/addresources/values/strings.xml

8ad3eaf

Co-authored-by: oSumAtrIX <[email protected]>

Merge branch 'dev' into fork/fix_gmscore_adjust_dialog_text

c903949

# Conflicts: # src/main/resources/addresources/values/strings.xml

oSumAtrIX merged commit 82acb84 into ReVanced:dev Apr 6, 2024
2 checks passed

LisoUseInAIKyrios deleted the fix_gmscore_adjust_dialog_text branch April 6, 2024 18:47

ty114514 mentioned this pull request Apr 19, 2024

bug: Yt Music must disable battery optimization, which is different from before #3049

Closed

3 tasks

ReVanced locked as resolved and limited conversation to collaborators Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(YouTube - GmsCore support): Prompt to disable battery optimizations, if not done already #2958

fix(YouTube - GmsCore support): Prompt to disable battery optimizations, if not done already #2958

LisoUseInAIKyrios commented Mar 31, 2024 •

edited

Loading

oSumAtrIX commented Mar 31, 2024

LisoUseInAIKyrios commented Apr 1, 2024

LisoUseInAIKyrios commented Apr 3, 2024

d-e-n-n-i-s-t commented Apr 22, 2024

oSumAtrIX commented Apr 22, 2024

d-e-n-n-i-s-t commented Apr 22, 2024 •

edited

Loading

oSumAtrIX commented Apr 22, 2024

d-e-n-n-i-s-t commented Apr 22, 2024 •

edited

Loading

oSumAtrIX commented Apr 22, 2024

fix(YouTube - GmsCore support): Prompt to disable battery optimizations, if not done already #2958

fix(YouTube - GmsCore support): Prompt to disable battery optimizations, if not done already #2958

Conversation

LisoUseInAIKyrios commented Mar 31, 2024 • edited Loading

oSumAtrIX commented Mar 31, 2024

LisoUseInAIKyrios commented Apr 1, 2024

LisoUseInAIKyrios commented Apr 3, 2024

d-e-n-n-i-s-t commented Apr 22, 2024

oSumAtrIX commented Apr 22, 2024

d-e-n-n-i-s-t commented Apr 22, 2024 • edited Loading

oSumAtrIX commented Apr 22, 2024

d-e-n-n-i-s-t commented Apr 22, 2024 • edited Loading

oSumAtrIX commented Apr 22, 2024

LisoUseInAIKyrios commented Mar 31, 2024 •

edited

Loading

d-e-n-n-i-s-t commented Apr 22, 2024 •

edited

Loading

d-e-n-n-i-s-t commented Apr 22, 2024 •

edited

Loading