Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Toggle to disable battery optimization prompt at startup #3213

Closed
3 tasks done
hdd45 opened this issue May 21, 2024 · 5 comments
Closed
3 tasks done

feat: Toggle to disable battery optimization prompt at startup #3213

hdd45 opened this issue May 21, 2024 · 5 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@hdd45
Copy link

hdd45 commented May 21, 2024

Feature description

Please add a toggle to hide new MicroG GMS core battery optimization prompt at startup.

It works seamlessly without doing so.

Motivation

ReVanced works absolutely fine without disabling battery optimization for new MicroG, but it always prompts at startup. Please add a toggle to disable this prompt. Thank You

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@hdd45 hdd45 added the Feature request Requesting a new feature that's not implemented yet label May 21, 2024
@LisoUseInAIKyrios
Copy link
Contributor

Issue has been discussed many times before

#3092 (comment)

If YT works without turning off optimizations, then your device is already not optimizing the battery and "turning off" optimizations does nothing.

If you want to avoid this, then root your device and install YT without GmsCore support.

@LisoUseInAIKyrios LisoUseInAIKyrios closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@oSumAtrIX
Copy link
Member

If you can show any differences with and without optimization (send screenshots for example) we can consider adding an option to disable the prompt

@hdd45
Copy link
Author

hdd45 commented May 21, 2024

that's what I'm saying, there aren't any differences with and without optimization. so, the prompt is just useless for me. I wish I could disable it. adding a toggle to hide it isn't a big deal I guess.

@oSumAtrIX
Copy link
Member

Disabling battery optimization removes the prompt.

@hdd45
Copy link
Author

hdd45 commented May 22, 2024

Screenshot_2024-05-22-11-02-21-361_com miui home
Screenshot_2024-05-22-11-02-38-434_app revanced android youtube
Even If I restrict the background usage of microg, YouTube works perfectly fine then what's the need to disable the battery optimisations.

There are lots of toggles to hide even minute things in YouTube, what is the harm in adding a toggle for this.

If you don't wanna add such option, I'm no one to force you. BTW thanks for all these patches.
Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants