This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
feat: Add Check environment patch
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
oSumAtrIX
commented
Sep 1, 2024
app/src/main/java/app/revanced/integrations/shared/checks/Check.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
commented
Sep 1, 2024
app/src/main/java/app/revanced/integrations/shared/checks/Check.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/Check.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
commented
Sep 1, 2024
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/Check.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/Check.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/Check.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
LisoUseInAIKyrios
force-pushed
the
feat/check-env
branch
2 times, most recently
from
2c3f101 to
8e4acec
Compare
…on null. Do not export environment check setting (setting can still be overwrote by adding to import text). Fix dialog not showing on top of announcements.
LisoUseInAIKyrios
force-pushed
the
feat/check-env
branch
from
8e4acec to
d7bbf18
Compare
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Show resolved
Hide resolved
|
Since the device hardware hash will be very unique and always present when patching with Manager, that could be the primary way to validate. And to handle CLI, the patch time check and ip address could be used for that. Checking if the install source is not Manager or null (indicating CLI install) could be used to immediately fail the check since that means its 100% certain it's not installed by CLI or Manager. |
…mmediate pass to all other checks
… this check isn't needed to validate a CLI install
…uld go and there's already a button for that
…sure zero false positives for normal usage
LisoUseInAIKyrios
force-pushed
the
feat/check-env
branch
from
8356beb to
9495fae
Compare
LisoUseInAIKyrios
force-pushed
the
feat/check-env
branch
from
5e6172c to
51bf121
Compare
…old the patched apk is if other checks fail. Infer installer source failed if Manager is the source but no hardware hash codes are present.
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
…ing if app data is cleared more than 12 hours after app is first installed/updated.
… it's now always `unknown`
oSumAtrIX
commented
Sep 5, 2024
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Show resolved
Hide resolved
|
I can't request a review from the PR owner, but otherwise looks good. |
app/src/main/java/app/revanced/integrations/shared/checks/CheckEnvironmentPatch.java
Outdated
Show resolved
Hide resolved
|
Actually I just realized the time check can be done using only the installation time. It'll remove all false positives if the user clears the app data. I'll make a quick PR with the change in a moment. |
revanced-bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
# [1.14.0-dev.5](v1.14.0-dev.4...v1.14.0-dev.5) (2024-09-06) ### Features * Add `Check environment` patch ([#683](#683)) ([e856455](e856455))
revanced-bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
# [1.14.0](v1.13.0...v1.14.0) (2024-09-18) ### Bug Fixes * **YouTube - Check environment patch:** Allow adb installs even if patched more than 30 minutes ago ([5adf8bd](5adf8bd)) * **YouTube - Check environment patch:** Show if patched apk is too old, if the install source is not Manager or ADB ([18048f3](18048f3)) * **YouTube - Check environment patch:** Use app install/update time instead of current time ([#687](#687)) ([b0d82b0](b0d82b0)) * **YouTube - GmsCore support:** Show an error toast if GmsCore is included with root mounted installation ([#686](#686)) ([a4848be](a4848be)) * **YouTube - Hide layout components:** Hide new kind of community post ([#678](#678)) ([6be257a](6be257a)) * **YouTube - Return YouTube Dislike:** Show correct value when swiping back to prior Short and disliking ([2eb5e3a](2eb5e3a)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([#684](#684)) ([27d2b60](27d2b60)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([0f5dfb4](0f5dfb4)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([01f084d](01f084d)) * **YouTube:** Fix issues related to playback by replace streaming data ([#680](#680)) ([0468235](0468235)) ### Features * Add `Check environment` patch ([#683](#683)) ([e856455](e856455)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([#691](#691)) ([6f3d2ff](6f3d2ff)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([#681](#681)) ([5314dd9](5314dd9)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([#679](#679)) ([2c471f3](2c471f3)) * **YouTube:** Add donation link to settings about screen ([#688](#688)) ([b816c45](b816c45))
github-actions bot
pushed a commit
to zainarbani/revanced-integrations
that referenced
this pull request
Oct 4, 2024
# [1.17.0-dev.1](v1.16.1...v1.17.0-dev.1) (2024-10-04) ### Bug Fixes * **YouTube - Check environment patch:** Allow adb installs even if patched more than 30 minutes ago ([5adf8bd](5adf8bd)) * **YouTube - Check environment patch:** Show if patched apk is too old, if the install source is not Manager or ADB ([18048f3](18048f3)) * **YouTube - Check environment patch:** Use app install/update time instead of current time ([ReVanced#687](https://github.com/zainarbani/revanced-integrations/issues/687)) ([b0d82b0](b0d82b0)) * **YouTube - Check environment:** Only use fields available since Android 8 ([ReVanced#693](https://github.com/zainarbani/revanced-integrations/issues/693)) ([c0829c3](c0829c3)) * **YouTube - Check watch history domain name resolution:** Do not show warning if network connection is flaky ([ReVanced#702](https://github.com/zainarbani/revanced-integrations/issues/702)) ([80482df](80482df)) * **YouTube - GmsCore support:** Show an error toast if GmsCore is included with root mounted installation ([ReVanced#686](https://github.com/zainarbani/revanced-integrations/issues/686)) ([a4848be](a4848be)) * **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#678](https://github.com/zainarbani/revanced-integrations/issues/678)) ([6be257a](6be257a)) * **YouTube - Hide layout components:** Hide new kind of community posts ([ReVanced#695](https://github.com/zainarbani/revanced-integrations/issues/695)) ([b384926](b384926)) * **YouTube - Return YouTube Dislike:** Show correct value when swiping back to prior Short and disliking ([2eb5e3a](2eb5e3a)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#684](https://github.com/zainarbani/revanced-integrations/issues/684)) ([27d2b60](27d2b60)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([0f5dfb4](0f5dfb4)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([01f084d](01f084d)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([a2e8bbb](a2e8bbb)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([ReVanced#697](https://github.com/zainarbani/revanced-integrations/issues/697)) ([d06706d](d06706d)) * **YouTube - Spoof video streams:** Handle app left open for a long time ([ReVanced#709](https://github.com/zainarbani/revanced-integrations/issues/709)) ([ea4b073](ea4b073)) * **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#680](https://github.com/zainarbani/revanced-integrations/issues/680)) ([0468235](0468235)) * **YouTube:** Show video chapter titles without clipping when overlay buttons are enabled ([ReVanced#699](https://github.com/zainarbani/revanced-integrations/issues/699)) ([325cc17](325cc17)) ### Features * Add `Check environment` patch ([ReVanced#683](https://github.com/zainarbani/revanced-integrations/issues/683)) ([e856455](e856455)) * Merge branch `feat/yt-bump` to `dev` ([48a7ac4](48a7ac4)) * **YouTube - Disable precise seeking gesture:** Hide "pull up" label that shows up when swiping ([ReVanced#696](https://github.com/zainarbani/revanced-integrations/issues/696)) ([0b9afd0](0b9afd0)) * **YouTube - Hide Shorts components:** Add `Hide save music`, `Hide stickers` ([ReVanced#703](https://github.com/zainarbani/revanced-integrations/issues/703)) ([a87456e](a87456e)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([ReVanced#708](https://github.com/zainarbani/revanced-integrations/issues/708)) ([16c3ef7](16c3ef7)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#691](https://github.com/zainarbani/revanced-integrations/issues/691)) ([6f3d2ff](6f3d2ff)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#681](https://github.com/zainarbani/revanced-integrations/issues/681)) ([5314dd9](5314dd9)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#679](https://github.com/zainarbani/revanced-integrations/issues/679)) ([2c471f3](2c471f3)) * **YouTube:** Add donation link to settings about screen ([ReVanced#688](https://github.com/zainarbani/revanced-integrations/issues/688)) ([b816c45](b816c45))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration changes for ReVanced/revanced-patches#3610