feat: Add `Check environment` patch #3610

oSumAtrIX · 2024-09-01T22:37:18Z

About

This PR adds a patch that checks and warns the user in case they have downloaded the app as a pre-patched APK or if the APK was not patched and installed using the expected means, such as ReVanced Manager or ReVanced CLI.

How it works

Several checks are run in sequence. Some checks may exempt others. One check is comparing the hardware of the device used to patch vs what device the app is then launched on. Another checks if the patch & install time is about the same. And another check verifies the installer source is either CLI or ReVanced Manager.

If the environment check is deemed to have failed, then a warning will be issued at the app launch. The warning will mention the current situation and explain why the warning is being shown by mentioning what kind of checks have failed. The warning has a button to open the source to patch and install an app as intended and a button to dismiss the warning. If the warning is ignored twice it will never be shown again. If the environment check is deemed successful, then the check will be disabled forever.

Quirks

Of course, while unlikely, false positives could still occur. A false positive can occur when you want to share your patched app with friends or family. The warning mentions what kind of checks lead to the warning, giving the user the required context to determine whether they should take the suggested action or ignore it.

Integration changes.

Todo

Check if the startup time is unaffected (Maybe run in a background thread?)
Resolve the remaining todo
Check that false positives unlikely occur
Verify the device build info check when installed from ReVanced Manager

src/main/resources/addresources/values/strings.xml

src/main/kotlin/app/revanced/patches/shared/misc/checks/BaseCheckEnvironmentPatch.kt

YT-Advanced · 2024-09-02T01:41:42Z

I don't think IP checking is needed.
And how can we detect if user patched the app via CLI ._.

oSumAtrIX · 2024-09-02T01:52:42Z

Both, the time and ip check will succeed the check. If Android allows, an installation of ReVanced Manager will also let it pass

oSumAtrIX · 2024-09-02T11:18:06Z

@LisoUseInAIKyrios There are a couple of todos left in the code and the PR body. One important test is if everything works on Android. The patch code, for example, uses the URL connection, but it is unclear if it also needs to run in a background thread. Some issues also regarding the dialog. Other than that almost ready.

src/main/kotlin/app/revanced/patches/shared/misc/checks/BaseCheckEnvironmentPatch.kt

… this check isn't needed to validate a CLI install

…uld go and there's already a button for that

…atches to be specified

LisoUseInAIKyrios · 2024-09-03T21:21:07Z

The last TODO is verify the device hardware check passes when installed from ReVanced Manager. Doing that will require someone to make a release on their cloned repo, change the source in ReVanced Manager to that repo, then build and install.

The console logs will show Device hardware signature matches current device or Device hardware signature does not match current device

LisoUseInAIKyrios · 2024-09-03T22:48:30Z

To force the warning dialog to appear (even if the check passes), then open the import/export menu and add this as the first line of the settings:
"check_environment_warnings_issued": -1,
Press import button, and restart the app.

src/main/resources/addresources/values/strings.xml

Co-authored-by: KobeW50 <[email protected]>

src/main/resources/addresources/values/strings.xml

src/main/kotlin/app/revanced/patches/shared/misc/checks/BaseCheckEnvironmentPatch.kt

Co-authored-by: oSumAtrIX <[email protected]>

…ialog message and the buttons

# [4.14.0-dev.7](v4.14.0-dev.6...v4.14.0-dev.7) (2024-09-06) ### Features * Add `Check environment` patch ([#3610](#3610)) ([fbcbdaf](fbcbdaf))

LisoUseInAIKyrios · 2024-09-06T08:37:27Z

For future reference:

This warning will never be shown, if the user patches and installs by any of the following:

App is patched on the users own device using ReVanced Manager. No warning will evershow no matter how the patched apk is installed, including saving patched APK's to device and installing weeks or months later.
Patched using CLI tools and installed using ADB anytime (using computer command prompt, or Termux with ADB).
Patched using CLI tools and installed without ADB, and the app is installed within 15 minutes of patching.

cyberboh · 2024-09-06T12:43:43Z

Is this patch included by default? or inside universal patch?

oSumAtrIX · 2024-09-06T13:13:19Z

It is not universal and included for specific apps

cyberboh · 2024-09-06T13:19:20Z

It is not universal and included for specific apps

Can you specify which apps?

MarcaDian · 2024-09-06T13:28:21Z

Can you specify which apps?

revanced-patches/src/main/kotlin/app/revanced/patches/youtube/misc/check/CheckEnvironmentPatch.kt

Line 12 in a7115d7

compatiblePackages = setOf(CompatiblePackage("com.google.android.youtube")),

# [4.14.0-dev.1](v4.13.3...v4.14.0-dev.1) (2024-09-09) ### Bug Fixes * **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/E85Addict/revanced-patches/issues/3616)) ([98956e8](98956e8)) * **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/E85Addict/revanced-patches/issues/3558)) ([0f5a771](0f5a771)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/E85Addict/revanced-patches/issues/3601)) ([005be82](005be82)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1)) ### Features * Add `Change data directory location` patch ([ReVanced#3602](https://github.com/E85Addict/revanced-patches/issues/3602)) ([5998029](5998029)) * Add `Check environment` patch ([ReVanced#3610](https://github.com/E85Addict/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf)) * **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/E85Addict/revanced-patches/issues/3422)) ([d0a8599](d0a8599)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/E85Addict/revanced-patches/issues/3592)) ([f5fb351](f5fb351)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/E85Addict/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f)) * **YouTube:** Support versions 19.17 thru 19.30 ([a69c4f3](a69c4f3))

# [4.14.0](v4.13.3...v4.14.0) (2024-09-18) ### Bug Fixes * **Pixiv - Hide ads:** Fix for latest version ([#3616](#3616)) ([98956e8](98956e8)) * **Soundcloud - Hide ads:** Support latest version ([#3628](#3628)) ([66e7e33](66e7e33)) * **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([#3558](#3558)) ([0f5a771](0f5a771)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([#3601](#3601)) ([005be82](005be82)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1)) * **YouTube:** Fix issues related to playback by replace streaming data ([#3582](#3582)) ([dfa94d7](dfa94d7)) ### Features * Add `Change data directory location` patch ([#3602](#3602)) ([5998029](5998029)) * Add `Check environment` patch ([#3610](#3610)) ([fbcbdaf](fbcbdaf)) * **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([#3422](#3422)) ([d0a8599](d0a8599)) * **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3)) * **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([#3647](#3647)) ([33fc090](33fc090)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([#3592](#3592)) ([f5fb351](f5fb351)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([#3570](#3570)) ([1a49d1f](1a49d1f)) * **YouTube Music:** Make working patches compatible with latest versions ([#3556](#3556)) ([12f6f19](12f6f19)) * **YouTube:** Add donation link to settings about screen ([#3626](#3626)) ([0684ab5](0684ab5))

# [4.14.0](v4.13.3...v4.14.0) (2024-09-18) ### Bug Fixes * **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/E85Addict/revanced-patches/issues/3616)) ([98956e8](98956e8)) * **Soundcloud - Hide ads:** Support latest version ([ReVanced#3628](https://github.com/E85Addict/revanced-patches/issues/3628)) ([66e7e33](66e7e33)) * **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/E85Addict/revanced-patches/issues/3558)) ([0f5a771](0f5a771)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/E85Addict/revanced-patches/issues/3601)) ([005be82](005be82)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1)) * **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#3582](https://github.com/E85Addict/revanced-patches/issues/3582)) ([dfa94d7](dfa94d7)) ### Features * Add `Change data directory location` patch ([ReVanced#3602](https://github.com/E85Addict/revanced-patches/issues/3602)) ([5998029](5998029)) * Add `Check environment` patch ([ReVanced#3610](https://github.com/E85Addict/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf)) * **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/E85Addict/revanced-patches/issues/3422)) ([d0a8599](d0a8599)) * **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3)) * **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#3647](https://github.com/E85Addict/revanced-patches/issues/3647)) ([33fc090](33fc090)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/E85Addict/revanced-patches/issues/3592)) ([f5fb351](f5fb351)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/E85Addict/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f)) * **YouTube Music:** Make working patches compatible with latest versions ([ReVanced#3556](https://github.com/E85Addict/revanced-patches/issues/3556)) ([12f6f19](12f6f19)) * **YouTube:** Add donation link to settings about screen ([ReVanced#3626](https://github.com/E85Addict/revanced-patches/issues/3626)) ([0684ab5](0684ab5)) ### Performance Improvements * Personal Logo && Add upstream sync ([2e4ef0a](2e4ef0a))

# [4.14.0-dev.1](v4.13.3...v4.14.0-dev.1) (2024-10-04) ### Bug Fixes * **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/zainarbani/revanced-patches/issues/3616)) ([98956e8](98956e8)) * **Soundcloud - Hide ads:** Support latest version ([ReVanced#3628](https://github.com/zainarbani/revanced-patches/issues/3628)) ([66e7e33](66e7e33)) * **Soundcloud:** Support latest versions ([ReVanced#3702](https://github.com/zainarbani/revanced-patches/issues/3702)) ([099ac5e](099ac5e)) * **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/zainarbani/revanced-patches/issues/3558)) ([0f5a771](0f5a771)) * **TikTok - Playback speed:** Prevent crash by fixing invalid patch ([82d53cb](82d53cb)) * **TikTok - Settings:** Prevent crash by fixing invalid patch ([8074032](8074032)) * **Twitter - Open links with app chooser:** Constrain patch to last working version `10.48.0-release` ([b9955d5](b9955d5)) * **Twitter - Open links with app chooser:** Fix incorrect version in compatibility list ([ReVanced#3683](https://github.com/zainarbani/revanced-patches/issues/3683)) ([adafe85](adafe85)) * **YouTube - Check environment:** Only use fields available since Android 8 ([ReVanced#3655](https://github.com/zainarbani/revanced-patches/issues/3655)) ([4413533](4413533)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/zainarbani/revanced-patches/issues/3601)) ([005be82](005be82)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f)) * **YouTube - SponsorBlock:** Fade out SB buttons without overlapping other buttons ([ReVanced#3719](https://github.com/zainarbani/revanced-patches/issues/3719)) ([bf96108](bf96108)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([74c8637](74c8637)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([ReVanced#3672](https://github.com/zainarbani/revanced-patches/issues/3672)) ([a3306f6](a3306f6)) * **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#3582](https://github.com/zainarbani/revanced-patches/issues/3582)) ([dfa94d7](dfa94d7)) * **YouTube:** Show video chapter titles without clipping when overlay buttons are enabled ([ReVanced#3674](https://github.com/zainarbani/revanced-patches/issues/3674)) ([4b88c31](4b88c31)) ### Features * Add `Change data directory location` patch ([ReVanced#3602](https://github.com/zainarbani/revanced-patches/issues/3602)) ([5998029](5998029)) * Add `Check environment` patch ([ReVanced#3610](https://github.com/zainarbani/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf)) * **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/zainarbani/revanced-patches/issues/3422)) ([d0a8599](d0a8599)) * **Google Photos:** Restore hidden 'Back up while charging' toggle ([ReVanced#3678](https://github.com/zainarbani/revanced-patches/issues/3678)) ([f9e19ce](f9e19ce)) * **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3)) * **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49)) * **TikTok:** Bump patches to support the latest version 36.5.4 ([e5dcb72](e5dcb72)) * **YouTube - Disable precise seeking gesture:** Hide "pull up" label that shows up when swiping ([ReVanced#3668](https://github.com/zainarbani/revanced-patches/issues/3668)) ([3fa8af9](3fa8af9)) * **YouTube - Hide Shorts components:** Add `Hide save music`, `Hide stickers` ([ReVanced#3710](https://github.com/zainarbani/revanced-patches/issues/3710)) ([8c99321](8c99321)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([ReVanced#3731](https://github.com/zainarbani/revanced-patches/issues/3731)) ([00a99dd](00a99dd)) * **YouTube - Hide Shorts components:** Add patch option to hide Shorts app shortcut (long press app icon) ([ReVanced#3699](https://github.com/zainarbani/revanced-patches/issues/3699)) ([0d4e1f5](0d4e1f5)) * **YouTube - Hide Shorts components:** Add patch option to hide Shorts from app launcher widget Beta ([ReVanced#3707](https://github.com/zainarbani/revanced-patches/issues/3707)) ([838f183](838f183)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#3647](https://github.com/zainarbani/revanced-patches/issues/3647)) ([33fc090](33fc090)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/zainarbani/revanced-patches/issues/3592)) ([f5fb351](f5fb351)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/zainarbani/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f)) * **YouTube Music:** Make working patches compatible with latest versions ([ReVanced#3556](https://github.com/zainarbani/revanced-patches/issues/3556)) ([12f6f19](12f6f19)) * **YouTube:** Add donation link to settings about screen ([ReVanced#3626](https://github.com/zainarbani/revanced-patches/issues/3626)) ([0684ab5](0684ab5))

# [4.18.0-dev.1](v4.17.1...v4.18.0-dev.1) (2024-10-04) ### Bug Fixes * **Pixiv - Hide ads:** Fix for latest version ([ReVanced#3616](https://github.com/zainarbani/revanced-patches/issues/3616)) ([98956e8](98956e8)) * **Soundcloud - Hide ads:** Support latest version ([ReVanced#3628](https://github.com/zainarbani/revanced-patches/issues/3628)) ([66e7e33](66e7e33)) * **Soundcloud:** Support latest versions ([ReVanced#3702](https://github.com/zainarbani/revanced-patches/issues/3702)) ([099ac5e](099ac5e)) * **SwissID:** Rename `Remove Google Play Integrity Integrity check` to `Remove Google Play Integrity check` ([ReVanced#3558](https://github.com/zainarbani/revanced-patches/issues/3558)) ([0f5a771](0f5a771)) * **TikTok - Playback speed:** Prevent crash by fixing invalid patch ([82d53cb](82d53cb)) * **TikTok - Settings:** Prevent crash by fixing invalid patch ([8074032](8074032)) * **Twitter - Open links with app chooser:** Constrain patch to last working version `10.48.0-release` ([b9955d5](b9955d5)) * **Twitter - Open links with app chooser:** Fix incorrect version in compatibility list ([ReVanced#3683](https://github.com/zainarbani/revanced-patches/issues/3683)) ([adafe85](adafe85)) * **YouTube - Check environment:** Only use fields available since Android 8 ([ReVanced#3655](https://github.com/zainarbani/revanced-patches/issues/3655)) ([4413533](4413533)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#3601](https://github.com/zainarbani/revanced-patches/issues/3601)) ([005be82](005be82)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([df80b9f](df80b9f)) * **YouTube - SponsorBlock:** Fade out SB buttons without overlapping other buttons ([ReVanced#3719](https://github.com/zainarbani/revanced-patches/issues/3719)) ([bf96108](bf96108)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([37b3dd1](37b3dd1)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([74c8637](74c8637)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([ReVanced#3672](https://github.com/zainarbani/revanced-patches/issues/3672)) ([a3306f6](a3306f6)) * **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#3582](https://github.com/zainarbani/revanced-patches/issues/3582)) ([dfa94d7](dfa94d7)) * **YouTube:** Show video chapter titles without clipping when overlay buttons are enabled ([ReVanced#3674](https://github.com/zainarbani/revanced-patches/issues/3674)) ([4b88c31](4b88c31)) ### Features * Add `Change data directory location` patch ([ReVanced#3602](https://github.com/zainarbani/revanced-patches/issues/3602)) ([5998029](5998029)) * Add `Check environment` patch ([ReVanced#3610](https://github.com/zainarbani/revanced-patches/issues/3610)) ([fbcbdaf](fbcbdaf)) * **Duolingo:** Add `Disable ads` and `Enable debug menu` patch ([ReVanced#3422](https://github.com/zainarbani/revanced-patches/issues/3422)) ([d0a8599](d0a8599)) * **Google Photos:** Restore hidden 'Back up while charging' toggle ([ReVanced#3678](https://github.com/zainarbani/revanced-patches/issues/3678)) ([f9e19ce](f9e19ce)) * **Sync for Reddit:** Add `Fix /user/ endpoint` patch ([46d11f3](46d11f3)) * **Sync for Reddit:** Rename patch to `Use /user/ endpoint` ([98ead49](98ead49)) * **TikTok:** Bump patches to support the latest version 36.5.4 ([e5dcb72](e5dcb72)) * **YouTube - Disable precise seeking gesture:** Hide "pull up" label that shows up when swiping ([ReVanced#3668](https://github.com/zainarbani/revanced-patches/issues/3668)) ([3fa8af9](3fa8af9)) * **YouTube - Hide Shorts components:** Add `Hide save music`, `Hide stickers` ([ReVanced#3710](https://github.com/zainarbani/revanced-patches/issues/3710)) ([8c99321](8c99321)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([ReVanced#3731](https://github.com/zainarbani/revanced-patches/issues/3731)) ([00a99dd](00a99dd)) * **YouTube - Hide Shorts components:** Add patch option to hide Shorts app shortcut (long press app icon) ([ReVanced#3699](https://github.com/zainarbani/revanced-patches/issues/3699)) ([0d4e1f5](0d4e1f5)) * **YouTube - Hide Shorts components:** Add patch option to hide Shorts from app launcher widget Beta ([ReVanced#3707](https://github.com/zainarbani/revanced-patches/issues/3707)) ([838f183](838f183)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#3647](https://github.com/zainarbani/revanced-patches/issues/3647)) ([33fc090](33fc090)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#3592](https://github.com/zainarbani/revanced-patches/issues/3592)) ([f5fb351](f5fb351)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#3570](https://github.com/zainarbani/revanced-patches/issues/3570)) ([1a49d1f](1a49d1f)) * **YouTube Music:** Make working patches compatible with latest versions ([ReVanced#3556](https://github.com/zainarbani/revanced-patches/issues/3556)) ([12f6f19](12f6f19)) * **YouTube:** Add donation link to settings about screen ([ReVanced#3626](https://github.com/zainarbani/revanced-patches/issues/3626)) ([0684ab5](0684ab5))

feat: Add Check environment patch

bd69298

oSumAtrIX requested a review from LisoUseInAIKyrios September 1, 2024 22:37

oSumAtrIX commented Sep 1, 2024

View reviewed changes

src/main/resources/addresources/values/strings.xml Outdated Show resolved Hide resolved

oSumAtrIX commented Sep 1, 2024

View reviewed changes

src/main/kotlin/app/revanced/patches/shared/misc/checks/BaseCheckEnvironmentPatch.kt Outdated Show resolved Hide resolved

move check before calling function

87e2d0e

oSumAtrIX commented Sep 1, 2024

View reviewed changes

src/main/kotlin/app/revanced/patches/shared/misc/checks/BaseCheckEnvironmentPatch.kt Show resolved Hide resolved

oSumAtrIX added 4 commits September 2, 2024 00:45

rename method

20d001d

use activity context

0c3865a

small changes

5acebd2

Use last three digits to prevent brute forcing the hashed IP

f1036e0

fix some issues add todos

6280d13

LisoUseInAIKyrios mentioned this pull request Sep 2, 2024

feat: Add Check environment patch ReVanced/revanced-integrations#683

Merged

LisoUseInAIKyrios reviewed Sep 2, 2024

View reviewed changes

src/main/kotlin/app/revanced/patches/shared/misc/checks/BaseCheckEnvironmentPatch.kt Outdated Show resolved Hide resolved

LisoUseInAIKyrios added 9 commits September 2, 2024 19:31

refactor

fed02f8

fix: Check data returned from ip service. Try other services if needed.

29506c2

fix: Remove Check if manager is installed

285131d

fix: Remove ip check that sometimes fails due to privacy concerns and…

dbcea08

… this check isn't needed to validate a CLI install

fix: Remove social media links, as the main website is where they sho…

2f74e88

…uld go and there's already a button for that

fix: Don't show any dialog buttons until after a few seconds

19a1b53

fix: Adjust text

e64ba5b

fix: Adjust text

116d343

fix: Add patch as dependency to Settings, until a way for mandatory p…

e0fcbe1

…atches to be specified

LisoUseInAIKyrios marked this pull request as ready for review September 3, 2024 21:14

fix: Remove unused network address code

1329337

fix: adjust text

5840c75

KobeW50 reviewed Sep 3, 2024

View reviewed changes

src/main/resources/addresources/values/strings.xml Outdated Show resolved Hide resolved

LisoUseInAIKyrios and others added 7 commits September 3, 2024 19:39

Update src/main/resources/addresources/values/strings.xml

f4132cd

Co-authored-by: KobeW50 <[email protected]>

fix: Adjust text

4a9793e

fix: Show how old the patched apk is if any other checks fail

da65772

Remove name so the patch does not appear as selectable

fadd7a4

Fix correctness of strings

f52dd9f

fix: Use same base64 encoding for integrations and patches

ff969e3

fix: use UTF8 just in case Build has foreign characters

36de93c

oSumAtrIX commented Sep 5, 2024

View reviewed changes

src/main/resources/addresources/values/strings.xml Outdated Show resolved Hide resolved

oSumAtrIX commented Sep 5, 2024

View reviewed changes

src/main/kotlin/app/revanced/patches/shared/misc/checks/BaseCheckEnvironmentPatch.kt Show resolved Hide resolved

LisoUseInAIKyrios and others added 4 commits September 5, 2024 14:51

Update src/main/resources/addresources/values/strings.xml

98e143d

Co-authored-by: oSumAtrIX <[email protected]>

fix: Use more concise text

7620abf

fix: Use consistent line break elements

5f857a8

fix: Use paragraph for last element to add some padding between the d…

a7115d7

…ialog message and the buttons

LisoUseInAIKyrios approved these changes Sep 6, 2024

View reviewed changes

oSumAtrIX merged commit fbcbdaf into dev Sep 6, 2024
2 checks passed

oSumAtrIX deleted the feat/check-env branch September 6, 2024 08:26

revanced-bot pushed a commit that referenced this pull request Sep 6, 2024

chore(release): 4.14.0-dev.7 [skip ci]

532169d

# [4.14.0-dev.7](v4.14.0-dev.6...v4.14.0-dev.7) (2024-09-06) ### Features * Add `Check environment` patch ([#3610](#3610)) ([fbcbdaf](fbcbdaf))

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add `Check environment` patch #3610

feat: Add `Check environment` patch #3610

oSumAtrIX commented Sep 1, 2024 •

edited by LisoUseInAIKyrios

Loading

YT-Advanced commented Sep 2, 2024

oSumAtrIX commented Sep 2, 2024

oSumAtrIX commented Sep 2, 2024 •

edited

Loading

LisoUseInAIKyrios commented Sep 3, 2024

LisoUseInAIKyrios commented Sep 3, 2024

LisoUseInAIKyrios commented Sep 6, 2024

cyberboh commented Sep 6, 2024

oSumAtrIX commented Sep 6, 2024

cyberboh commented Sep 6, 2024

MarcaDian commented Sep 6, 2024

feat: Add Check environment patch #3610

feat: Add Check environment patch #3610

Conversation

oSumAtrIX commented Sep 1, 2024 • edited by LisoUseInAIKyrios Loading

About

How it works

Quirks

Todo

YT-Advanced commented Sep 2, 2024

oSumAtrIX commented Sep 2, 2024

oSumAtrIX commented Sep 2, 2024 • edited Loading

LisoUseInAIKyrios commented Sep 3, 2024

LisoUseInAIKyrios commented Sep 3, 2024

LisoUseInAIKyrios commented Sep 6, 2024

cyberboh commented Sep 6, 2024

oSumAtrIX commented Sep 6, 2024

cyberboh commented Sep 6, 2024

MarcaDian commented Sep 6, 2024

feat: Add `Check environment` patch #3610

feat: Add `Check environment` patch #3610

oSumAtrIX commented Sep 1, 2024 •

edited by LisoUseInAIKyrios

Loading

oSumAtrIX commented Sep 2, 2024 •

edited

Loading