This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
fix(YouTube): Fix issues related to playback by replace streaming data #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
A stream cache does not appear to be needed, as YT seems to be caching the streams when swiping thru Shorts. Streams have authentication time limits as well so it's easier and more reliable to just fetch again if the same video is closed then reopened. Can use a regular Future as none of the features of CompletableFuture is being used here. Using an executor future also avoids any potential StrictMode policy violations if the calling YT thread is set to never make network calls.
…ilar to `iOS` and `Android VR`
LisoUseInAIKyrios
force-pushed
the
fix/yt-spoof-stream
branch
from
094d608 to
06824a8
Compare
zainarbani
commented
Aug 26, 2024
app/src/main/java/app/revanced/integrations/youtube/patches/spoof/ClientType.java
Outdated
Show resolved
Hide resolved
LisoUseInAIKyrios
force-pushed
the
fix/yt-spoof-stream
branch
from
948a1b0 to
0817016
Compare
LisoUseInAIKyrios
force-pushed
the
fix/yt-spoof-stream
branch
from
0817016 to
bfe7faa
Compare
zainarbani
commented
Aug 27, 2024
app/src/main/java/app/revanced/integrations/youtube/patches/spoof/ClientType.java
Outdated
Show resolved
Hide resolved
kitadai31
reviewed
Aug 31, 2024
app/src/main/java/app/revanced/integrations/youtube/patches/spoof/DeviceHardwareSupport.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
app/src/main/java/app/revanced/integrations/youtube/patches/spoof/SpoofClientPatch.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
app/src/main/java/app/revanced/integrations/youtube/patches/spoof/SpoofClientPatch.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
app/src/main/java/app/revanced/integrations/youtube/patches/spoof/SpoofClientPatch.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
...main/java/app/revanced/integrations/youtube/patches/spoof/requests/StreamingDataRequest.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
...main/java/app/revanced/integrations/youtube/patches/spoof/requests/StreamingDataRequest.java
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
...main/java/app/revanced/integrations/youtube/patches/spoof/requests/StreamingDataRequest.java
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
...main/java/app/revanced/integrations/youtube/patches/spoof/requests/StreamingDataRequest.java
Show resolved
Hide resolved
oSumAtrIX
reviewed
Sep 10, 2024
...main/java/app/revanced/integrations/youtube/patches/spoof/requests/StreamingDataRequest.java
Show resolved
Hide resolved
LisoUseInAIKyrios
force-pushed
the
fix/yt-spoof-stream
branch
from
dff69e7 to
45740b2
Compare
…ould be changed unknowingly
LisoUseInAIKyrios
force-pushed
the
fix/yt-spoof-stream
branch
from
a0a675a to
69f0314
Compare
…ces without VP9 hardware decoding
LisoUseInAIKyrios
force-pushed
the
fix/yt-spoof-stream
branch
from
2c7f5d6 to
40a488f
Compare
oSumAtrIX
changed the title
oSumAtrIX
approved these changes
Sep 17, 2024
LisoUseInAIKyrios
approved these changes
Sep 17, 2024
revanced-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
# [1.14.0-dev.12](v1.14.0-dev.11...v1.14.0-dev.12) (2024-09-17) ### Bug Fixes * **YouTube:** Fix issues related to playback by replace streaming data ([#680](#680)) ([0468235](0468235))
revanced-bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
# [1.14.0](v1.13.0...v1.14.0) (2024-09-18) ### Bug Fixes * **YouTube - Check environment patch:** Allow adb installs even if patched more than 30 minutes ago ([5adf8bd](5adf8bd)) * **YouTube - Check environment patch:** Show if patched apk is too old, if the install source is not Manager or ADB ([18048f3](18048f3)) * **YouTube - Check environment patch:** Use app install/update time instead of current time ([#687](#687)) ([b0d82b0](b0d82b0)) * **YouTube - GmsCore support:** Show an error toast if GmsCore is included with root mounted installation ([#686](#686)) ([a4848be](a4848be)) * **YouTube - Hide layout components:** Hide new kind of community post ([#678](#678)) ([6be257a](6be257a)) * **YouTube - Return YouTube Dislike:** Show correct value when swiping back to prior Short and disliking ([2eb5e3a](2eb5e3a)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([#684](#684)) ([27d2b60](27d2b60)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([0f5dfb4](0f5dfb4)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([01f084d](01f084d)) * **YouTube:** Fix issues related to playback by replace streaming data ([#680](#680)) ([0468235](0468235)) ### Features * Add `Check environment` patch ([#683](#683)) ([e856455](e856455)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([#691](#691)) ([6f3d2ff](6f3d2ff)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([#681](#681)) ([5314dd9](5314dd9)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([#679](#679)) ([2c471f3](2c471f3)) * **YouTube:** Add donation link to settings about screen ([#688](#688)) ([b816c45](b816c45))
github-actions bot
pushed a commit
to zainarbani/revanced-integrations
that referenced
this pull request
Oct 4, 2024
# [1.17.0-dev.1](v1.16.1...v1.17.0-dev.1) (2024-10-04) ### Bug Fixes * **YouTube - Check environment patch:** Allow adb installs even if patched more than 30 minutes ago ([5adf8bd](5adf8bd)) * **YouTube - Check environment patch:** Show if patched apk is too old, if the install source is not Manager or ADB ([18048f3](18048f3)) * **YouTube - Check environment patch:** Use app install/update time instead of current time ([ReVanced#687](https://github.com/zainarbani/revanced-integrations/issues/687)) ([b0d82b0](b0d82b0)) * **YouTube - Check environment:** Only use fields available since Android 8 ([ReVanced#693](https://github.com/zainarbani/revanced-integrations/issues/693)) ([c0829c3](c0829c3)) * **YouTube - Check watch history domain name resolution:** Do not show warning if network connection is flaky ([ReVanced#702](https://github.com/zainarbani/revanced-integrations/issues/702)) ([80482df](80482df)) * **YouTube - GmsCore support:** Show an error toast if GmsCore is included with root mounted installation ([ReVanced#686](https://github.com/zainarbani/revanced-integrations/issues/686)) ([a4848be](a4848be)) * **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#678](https://github.com/zainarbani/revanced-integrations/issues/678)) ([6be257a](6be257a)) * **YouTube - Hide layout components:** Hide new kind of community posts ([ReVanced#695](https://github.com/zainarbani/revanced-integrations/issues/695)) ([b384926](b384926)) * **YouTube - Return YouTube Dislike:** Show correct value when swiping back to prior Short and disliking ([2eb5e3a](2eb5e3a)) * **YouTube - ReturnYouTubeDislike:** Show estimated like count for videos with hidden likes ([ReVanced#684](https://github.com/zainarbani/revanced-integrations/issues/684)) ([27d2b60](27d2b60)) * **YouTube - SponsorBlock:** Add summary text to 'view my segments' button ([0f5dfb4](0f5dfb4)) * **YouTube - SponsorBlock:** Handle if the user enters an invalid number into any SB settings ([01f084d](01f084d)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([a2e8bbb](a2e8bbb)) * **YouTube - Spoof video streams:** Change default client type to Android VR ([ReVanced#697](https://github.com/zainarbani/revanced-integrations/issues/697)) ([d06706d](d06706d)) * **YouTube - Spoof video streams:** Handle app left open for a long time ([ReVanced#709](https://github.com/zainarbani/revanced-integrations/issues/709)) ([ea4b073](ea4b073)) * **YouTube:** Fix issues related to playback by replace streaming data ([ReVanced#680](https://github.com/zainarbani/revanced-integrations/issues/680)) ([0468235](0468235)) * **YouTube:** Show video chapter titles without clipping when overlay buttons are enabled ([ReVanced#699](https://github.com/zainarbani/revanced-integrations/issues/699)) ([325cc17](325cc17)) ### Features * Add `Check environment` patch ([ReVanced#683](https://github.com/zainarbani/revanced-integrations/issues/683)) ([e856455](e856455)) * Merge branch `feat/yt-bump` to `dev` ([48a7ac4](48a7ac4)) * **YouTube - Disable precise seeking gesture:** Hide "pull up" label that shows up when swiping ([ReVanced#696](https://github.com/zainarbani/revanced-integrations/issues/696)) ([0b9afd0](0b9afd0)) * **YouTube - Hide Shorts components:** Add `Hide save music`, `Hide stickers` ([ReVanced#703](https://github.com/zainarbani/revanced-integrations/issues/703)) ([a87456e](a87456e)) * **YouTube - Hide Shorts components:** Add option to hide like fountain ([ReVanced#708](https://github.com/zainarbani/revanced-integrations/issues/708)) ([16c3ef7](16c3ef7)) * **YouTube - Hide Shorts components:** Hide 'Use this sound' button ([ReVanced#691](https://github.com/zainarbani/revanced-integrations/issues/691)) ([6f3d2ff](6f3d2ff)) * **YouTube - Keyword filter:** Add syntax to match whole keywords and not substrings ([ReVanced#681](https://github.com/zainarbani/revanced-integrations/issues/681)) ([5314dd9](5314dd9)) * **YouTube - Spoof client:** Allow forcing AVC codec with iOS ([ReVanced#679](https://github.com/zainarbani/revanced-integrations/issues/679)) ([2c471f3](2c471f3)) * **YouTube:** Add donation link to settings about screen ([ReVanced#688](https://github.com/zainarbani/revanced-integrations/issues/688)) ([b816c45](b816c45))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrations for: ReVanced/revanced-patches#3582