-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more). Some fixes. #1906
Conversation
…icitGemmGTCDynamicWrwXdlopsNHWC.
…plicitGemmGTCDynamic(Fwd|Bwd)Xdlops
…h results in omission of all custom tests
…d() check from ConvAsm1x1UV2 is it does not support FP16
…ltipassWrW (3-3 only)
…t potential performance degradation after tests.
…mmGTCDynamicFwdXdlopsNHWC
…mmGTCDynamicBwdXdlopsNHWC
…mmGTCDynamicWrwXdlopsNHWC
…mmGTCDynamicFwdDlopsNCHWC
…t-solver-03 # RESOLVED Conflicts: # test/CMakeLists.txt
# RESOLVED Conflicts: # test/CMakeLists.txt
Started CI on the latest commit. |
@atamazov this PR has some issues with |
# RESOLVED Conflicts: # test/CMakeLists.txt
…moke_solver_Conv*
…ST_FLOAT_ARG where TEST_CONV_VERBOSE_F/B/W is already used.
CI started |
# RESOLVED Conflicts: # src/solver/conv_hip_implicit_gemm_bwd_v1r1.cpp
@junliume @johnny-keker Wait... there is an issue in smoke_solver_ConvHipImplicitGemmV4R1 |
|
…o override WORKAROUND_iGemm_936 from Jenkinsfile.
@junliume Thanks, I see. This is different issue related to W/A for #936 in Jenkinsfile. @junliume @johnny-keker Ready for the next round of CI testing. |
@junliume https://github.com/ROCmSoftwarePlatform/MIOpen/labels/TESTING_CI_PASSED can we go ahead and merge? |
@junliume Thanks! |
add_custom_test(smoke_solver_ConvBinWinogradRxSf2x3g1 GFX900_DISABLED GFX103X_ENABLED HALF_ENABLED SKIP_XNACK_ON | ||
COMMAND MIOPEN_DEBUG_CONVOLUTION_ATTRIB_FP16_ALT_IMPL=0 | ||
MIOPEN_FIND_MODE=normal MIOPEN_DEBUG_FIND_ONLY_SOLVER=ConvBinWinogradRxSf2x3g1 $<TARGET_FILE:test_conv2d> | ||
--input 1 40 20 20 --weights 20 40 3 3 --pads_strides_dilations 1 1 1 1 1 1 ${MIOPEN_TEST_FLAGS_ARGS} | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicate. Will be removed in next PR.
@junliume https://github.com/ROCmSoftwarePlatform/MIOpen/labels/testing https://github.com/ROCmSoftwarePlatform/MIOpen/labels/urgency_high
Proposed reviewers: @averinevg @xinpin -- mostly to share knowledge, plus @shurale-nkn
TODO
GFX110X_ENABLED
where necessary.This PR adds smoke tests for conv solvers:
By products: