[tests] Added smoke tests for conv solvers (ConvAsmBwdWrW1x1 and more…

…). Some fixes. (#1906)
ROCm · Mar 14, 2023 · 837cf48 · 837cf48
1 parent 8639615
commit 837cf48
Show file tree

Hide file tree

Showing 3 changed files with 319 additions and 111 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -29,7 +29,7 @@ macro(set_var_to_condition var)
     if(${ARGN})
         set(${var} TRUE)
     else()
-        set(${name} FALSE)
+        set(${var} FALSE)
     endif()
 endmacro()
 

diff --git a/src/solver/conv_hip_implicit_gemm_bwd_v1r1.cpp b/src/solver/conv_hip_implicit_gemm_bwd_v1r1.cpp
@@ -644,8 +644,6 @@ bool ConvHipImplicitGemmBwdDataV1R1::IsApplicable(const ConvolutionContext& ctx,
     if(!problem.Is2d() && !(problem.Is3d() && problem.IsFp32()))
         return false;
 
-    // TBD Renable fp16 once the root cause of
-    // fp16 failures, observed in CI, is resolved.
     if(!(problem.IsFp32() || problem.IsBfp16()))
         return false;
     if(problem.group_counts != 1)
@@ -654,11 +652,9 @@ bool ConvHipImplicitGemmBwdDataV1R1::IsApplicable(const ConvolutionContext& ctx,
         return false;
 #if WORKAROUND_ISSUE_309
     if(problem.IsBfp16())
-        return false;
+        if(!miopen::IsEnabled(MIOPEN_DEBUG_CONV_IMPLICIT_GEMM_HIP_BWD_V1R1{}))
+            return false;
 #endif
-    if(ctx.GetStream().GetDeviceName() == "gfx90a" &&
-       problem.conv_problem.IsGfx90aFp16altRequired())
-        return false;
 
     const auto k = ProblemInterpreter::GetOutputChannelK(problem);
     if(k % GetEPackLength(ctx, problem, false) != 0)