Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CK][HIP] limit the range of several CK HIP kernels #2005

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[CK][HIP] limit the range of several CK HIP kernels #2005

merged 1 commit into from
Mar 2, 2023

Conversation

carlushuang
Copy link
Contributor

This can partial fix #2004 by limiting several CK HIP kernel within the range of 2G

@carlushuang carlushuang mentioned this pull request Mar 1, 2023
Closed
@junliume junliume changed the title limit the range of several CK HIP kernels [CK][HIP] limit the range of several CK HIP kernels Mar 1, 2023
junliume
junliume approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@junliume junliume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see series of PRs dated back from #243 and let's make sure this time we get all the CK kernels patched properly

@junliume junliume added this to the ROCm 5.5 milestone Mar 1, 2023
@junliume junliume merged commit ff88d3d into develop Mar 2, 2023
junliume pushed a commit that referenced this pull request Mar 2, 2023
@carlushuang @junliume
[HIP][iGEMM] limit the range of several CK HIP kernels (#2005)
4f4c7f0
@atamazov
Copy link
Contributor

atamazov commented Mar 2, 2023

@carlushuang @junliume 🔴
This requires find-db update to avoid perf drops in cases when the best solution is of ImplicitGemm algorithm.
Please set https://github.com/ROCmSoftwarePlatform/MIOpen/labels/IMPACTS_FIND_DB

@junliume junliume mentioned this pull request Mar 3, 2023
Merged
1 task
alexandraBara pushed a commit that referenced this pull request Mar 14, 2023
@carlushuang @alexandraBara
[HIP][iGEMM] limit the range of several CK HIP kernels (#2005)
f26f2fe
@junliume junliume deleted the wa_2004_2g branch April 17, 2023 14:52
@atamazov atamazov mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junliume junliume junliume approved these changes

@zjing14 zjing14 Awaiting requested review from zjing14

@asroy asroy Awaiting requested review from asroy

Assignees
No one assigned
Labels
TESTING_CI_PASSED urgency_high
Projects
None yet
Milestone
ROCm 5.5
Development

Successfully merging this pull request may close these issues.

[Bug][CK][Static Kernel][ConvHipImplicitGemmV4R1Fwd] Possible Overflow with Large Values of Channels
3 participants
@carlushuang @atamazov @junliume