Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire old qubes-vm-create dialog #393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retire old qubes-vm-create dialog #393

wants to merge 1 commit into from
+8 −1,318

Conversation

alimirjamali
Copy link
Contributor

@alimirjamali
Copy link
Contributor Author

Development notes: Adding python3-xdg to requirements to let the CI/CD tests run. Dependency was introduced during #375

@alimirjamali alimirjamali force-pushed the issue-6561-qubes-vm-create branch 2 times, most recently from be68559 to 14cc82d Compare November 10, 2024 18:13
@marmarek
Copy link
Member

As noted in the other issue, IMO better to simply remove the old create qube dialog (and replace its use with the new one).

@marmarek
Copy link
Member

marmarek commented Nov 14, 2024 •
edited
Loading

I'll pick just the dependency fix from here

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Nov 14, 2024 •
edited
Loading

As noted in the other issue, IMO better to simply remove the old create qube dialog (and replace its use with the new one).

OK. But I think it is better to do it for 4.3 branch and not 4.2. I will make a separate PR for the above task, properly ditching the old one. So it could be easily merged to 4.3 branch.

@marmarek
Copy link
Member

Well, "main" branch is "4.3 branch" :)

@alimirjamali alimirjamali marked this pull request as draft November 15, 2024 20:16
@alimirjamali alimirjamali force-pushed the issue-6561-qubes-vm-create branch from 14cc82d to c79cbf5 Compare November 16, 2024 19:39
@alimirjamali alimirjamali changed the title Add Create Qubes VM to the xfce4-panel menu Retire old qubes-vm-create dialog Nov 16, 2024
@alimirjamali alimirjamali marked this pull request as ready for review November 16, 2024 19:42
@marmarek marmarek requested a review from marmarta November 22, 2024 01:47
marmarta
marmarta suggested changes Nov 25, 2024
View reviewed changes
qubesmanager/qube_manager.py Outdated Show resolved Hide resolved
@alimirjamali alimirjamali force-pushed the issue-6561-qubes-vm-create branch from c79cbf5 to e4f6046 Compare November 25, 2024 13:22
@alimirjamali
Retire old qubes-vm-create dialog
210f867 
Retire the the old PyQt based `qubes-vm-create` dialog and replace it
with GTK based `qubes-new-qube` for Qube Manager.

resolves: QubesOS/qubes-issues#6561
@alimirjamali alimirjamali force-pushed the issue-6561-qubes-vm-create branch from e4f6046 to 210f867 Compare November 25, 2024 14:12
@qubesos-bot qubesos-bot mentioned this pull request Nov 26, 2024
Merged
10 tasks
@qubesos-bot
Copy link

qubesos-bot commented Nov 26, 2024 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024121602-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

  • system_tests_basic_vm_qrexec_gui

    • TC_30_Gui_daemon: test_002_clipboard_200k (failure)
      AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...

  • system_tests_extra

    • TC_00_QVCTest_debian-12-xfce: test_010_screenshare (failure)
      AssertionError: 7.933165427175505 not less than 2.0

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • system_tests_guivm_vnc_gui_interactive

    • guivm_manager: unnamed test (unknown)
    • guivm_manager: Failed (test died)
      # Test died: no candidate needle with tag(s) 'manager-vm-settings' ...

Failed tests

6 failures

  • system_tests_basic_vm_qrexec_gui

    • TC_30_Gui_daemon: test_002_clipboard_200k (failure)
      AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...

  • system_tests_extra

    • TC_00_QVCTest_debian-12-xfce: test_010_screenshare (failure)
      AssertionError: 7.933165427175505 not less than 2.0

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_guivm_vnc_gui_interactive

    • guivm_manager: unnamed test (unknown)
    • guivm_manager: Failed (test died)
      # Test died: no candidate needle with tag(s) 'manager-vm-settings' ...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

3 fixed

  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

  • system_tests_basic_vm_qrexec_gui_zfs

    • switch_pool: Failed (test died)
      # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...

  • system_tests_audio@hw1

Unstable tests

  • system_tests_audio

    TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
    • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...

  • system_tests_audio@hw1

    TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
    • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...

This was referenced Nov 26, 2024
Open
Merged
Merged
Merged
Open
Merged
Open
Merged
Merged
@qubesos-bot qubesos-bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 4, 2024
Merged
Merged
Open
This was referenced Dec 15, 2024
Open
Open
Open
Draft
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmarta marmarta marmarta approved these changes

Assignees
No one assigned
Labels
openqa-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include "Create Qubes VM" in System Tools in Applications Menu, so it shows up / is available in Whisker Menu
4 participants
@alimirjamali @marmarek @qubesos-bot @marmarta