Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix clipboard test #641

Merged
merged 2 commits into from
Dec 17, 2024
Merged

tests: fix clipboard test #641

merged 2 commits into from
Dec 17, 2024
+18 −8

Conversation

marmarek
Copy link
Member

First of all, wait for the zenity process to finish, do not leak it.

But then, adjust the test string to not be a single long line - zenity
often hangs on a single 300k line.

Fixes QubesOS/qubes-issues#9646

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (98855ca) to head (d4f6cdb).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   69.56%   69.45%   -0.11%     
==========================================
  Files          58       58              
  Lines       12465    12437      -28     
==========================================
- Hits         8671     8638      -33     
- Misses       3794     3799       +5
Flag Coverage Δ
unittests 69.45% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek
tests: fix clipboard test
3153306 
First of all, wait for the zenity process to finish, do not leak it.

But then, adjust the test string to not be a single long line - zenity
often hangs on a single 300k line.

Fixes QubesOS/qubes-issues#9646
This was referenced Dec 15, 2024
Merged
Merged
Merged
@qubesos-bot
Copy link

qubesos-bot commented Dec 15, 2024 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024121602-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

  • system_tests_basic_vm_qrexec_gui

    • TC_30_Gui_daemon: test_002_clipboard_200k (failure)
      AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...

  • system_tests_extra

    • TC_00_QVCTest_debian-12-xfce: test_010_screenshare (failure)
      AssertionError: 7.933165427175505 not less than 2.0

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • system_tests_guivm_gui_interactive

    • simple_gui_apps: unnamed test (unknown)

    • simple_gui_apps: Failed (test died)
      # Test died: no candidate needle with tag(s) 'vm-settings-app-evinc...

    • simple_gui_apps: unnamed test (unknown)

Failed tests

7 failures

  • system_tests_basic_vm_qrexec_gui

    • TC_30_Gui_daemon: test_002_clipboard_200k (failure)
      AssertionError: '' != 'test123ab\ntest123ab\ntest123ab\ntest123a[21...

  • system_tests_extra

    • TC_00_QVCTest_debian-12-xfce: test_010_screenshare (failure)
      AssertionError: 7.933165427175505 not less than 2.0

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_guivm_gui_interactive

    • simple_gui_apps: unnamed test (unknown)

    • simple_gui_apps: Failed (test died)
      # Test died: no candidate needle with tag(s) 'vm-settings-app-evinc...

    • simple_gui_apps: unnamed test (unknown)

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

3 fixed

  • system_tests_extra

    • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
      ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

  • system_tests_basic_vm_qrexec_gui_zfs

    • switch_pool: Failed (test died)
      # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...

  • system_tests_audio@hw1

Unstable tests

  • system_tests_basic_vm_qrexec_gui_zfs

    TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)
    • job 109480 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop6 device to...

  • system_tests_audio

    TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
    • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...

  • system_tests_audio@hw1

    TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
    • job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...

This was referenced Dec 15, 2024
Open
Open
Open
Open
Draft
Merged
Merged
@marmarek
Make "multimedia" devices more detailed
d4f6cdb 
Distinguish between audio, video and display adapters. This is
especially relevant when setting up sys-audio or sys-gui-gpu, otherwise
it's hard to find which "multimedia" device is the right one.
@marmarek marmarek merged commit d4f6cdb into QubesOS:main Dec 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
openqa-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build 202412140459-4.3] openQA test fails in test_002_clipboard_300k
2 participants
@marmarek @qubesos-bot