Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build 202412140459-4.3] openQA test fails in test_002_clipboard_300k #9646

Open
marmarek opened this issue Dec 14, 2024 · 3 comments · May be fixed by QubesOS/qubes-core-admin#641
Open

[Build 202412140459-4.3] openQA test fails in test_002_clipboard_300k #9646

marmarek opened this issue Dec 14, 2024 · 3 comments · May be fixed by QubesOS/qubes-core-admin#641
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: tests diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

Observation

openQA test in scenario qubesos-4.3-kernel-x86_64-system_tests_basic_vm_qrexec_gui@hw7 fails in
TC_30_Gui_daemon

Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 598, in cleanup_loop
    assert len(self.loop._selector.get_map()) == int(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        self.loop._ssock is not None
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ), (
    ^
AssertionError: unexpected selector map entries: {4: SelectorKey(fileobj=4, fd=4, events=1, data=(<Handle BaseSelectorEventLoop._read_from_self()>, None)), 62: SelectorKey(fileobj=62, fd=62, events=1, data=(<Handle PidfdChildWatcher._do_wait()>, None))}

Test suite description

Reproducible

Fails since (at least) Build 202412140459-4.3 (current job)

Expected result

Last good: 202411241734-4.3 (or more recent)

Further details

Always latest result in this scenario: latest

@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: tests P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. affects-4.3 This issue affects Qubes OS 4.3. labels Dec 14, 2024
@alimirjamali
Copy link

I have to study the QubesTestCase and its cleanup_loop to fully understand this. Is there a memory leak in INCR handling here?

@andrewdavidwong andrewdavidwong added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Dec 15, 2024
@marmarek
Copy link
Member Author

This looks like zenity is very slow with such a long text pasted. I have an idea for a fix.

@marmarek
Copy link
Member Author

The error in the issue description says more or less that some process remained running after the test.
And it looks to be zenity (via qrexec) - the first one, used to copy data from.

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 15, 2024
First of all, wait for the zenity process to finish, do not leak it.

But then, adjust the test string to not be a single long line - zenity
often hangs on a single 300k line.

Fixes QubesOS/qubes-issues#9646
@marmarek marmarek linked a pull request Dec 15, 2024 that will close this issue
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 15, 2024
First of all, wait for the zenity process to finish, do not leak it.

But then, adjust the test string to not be a single long line - zenity
often hangs on a single 300k line.

Fixes QubesOS/qubes-issues#9646
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 15, 2024
First of all, wait for the zenity process to finish, do not leak it.

But then, adjust the test string to not be a single long line - zenity
often hangs on a single 300k line.

Fixes QubesOS/qubes-issues#9646
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: tests diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants