Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify qubes-os XDG config directory #375

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

alimirjamali
Copy link
Contributor

fixes: QubesOS/qubes-issues#8694
Removing space and upper-case letters from qubes-manager configuration directory.
Migrating old config to new unified config directory.

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Jul 28, 2024

Making pylint happy(er)

p.s.: Added # pylint: disable-msg=too-many-statements for the time.

@alimirjamali alimirjamali force-pushed the Issue-8694 branch 2 times, most recently from f41993d to 82c933c Compare July 28, 2024 10:21
@marmarta
Copy link
Member

I really like this idea. The "The Qubes Project" directory is I think a very old tech debt from something someone wrote 10 yrs ago :D

qubesmanager/qube_manager.py Outdated Show resolved Hide resolved
@alimirjamali alimirjamali force-pushed the Issue-8694 branch 2 times, most recently from 4d279ab to 910036d Compare July 29, 2024 15:39
@alimirjamali
Copy link
Contributor Author

Making pylint happy(er) since the indents were wrong

@alimirjamali alimirjamali requested a review from marmarta July 29, 2024 19:37
fixes: QubesOS/qubes-issues#8694
Removing space and upper-case letters from qubes-manager configuration
directory. Migrating old config to new unified config directory.
Copy link

@ben-grande ben-grande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested. Looks good. Untested.

@marmarek marmarek merged commit 9ee6bd4 into QubesOS:main Sep 12, 2024
2 checks passed
@alimirjamali alimirjamali deleted the Issue-8694 branch October 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove space and upper-case letters from qubes-manager configuration directory
4 participants