-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wire_order option to all circuit drawers to allow defining the order of the wires #8173
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2657707261
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Some comments here and there. Also, considerting extending the tests for checking the warnings and exceptions discussed in #8063 (comment)
Done in a68cef7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Fixes #8063
Details and comments
This PR adds the
wire_order
kwarg tocircuit_drawer()
andQuantumCircuit.draw()
. It's entered as a list of bits, e.g.,The
wire_order
list must contain an entry for every bit, and the bits are numbered from 0 starting with the first qubit and continuing through the qubits and clbits.The
reverse_bits
option works as it did before, but it now uses the same code thatwire_order
uses.