Fix circuit drawers mutating input circuits #8741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wire management in the circuit drawers could accidentally mutate the qubits in the input circuit. The root cause of this is because `QuantumCircuit.qubits` (and `.clbits`) are properties that expose the internal, mutable lists that back them directly. This is a larger failing of the `QuantumCircuit` API, but one that is slightly tricky to walk back without backwards-incompatible changes or performance regressions.
jakelishman
added
Changelog: None
jakelishman
requested review from
a team,
nonhermitian and
nkanazawa1989
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
taalexander
approved these changes
Sep 14, 2022
Pull Request Test Coverage Report for Build 3049410146
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The wire management in the circuit drawers could accidentally mutate the qubits in the input circuit. The root cause of this is because
QuantumCircuit.qubits(and.clbits) are properties that expose the internal, mutable lists that back them directly. This is a larger failing of theQuantumCircuitAPI, but one that is slightly tricky to walk back without backwards-incompatible changes or performance regressions.Details and comments
Fix #8739. No release note because this regression was introduced by #8173, which hasn't been released yet.