Deprecating Provider ABC, as abstraction is not very useful #12145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
1ucian0
added
Changelog: None
Pull Request Test Coverage Report for Build 8802208992Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mtreinish
reviewed
Apr 18, 2024
1ucian0
commented
Apr 19, 2024
Co-authored-by: Matthew Treinish <[email protected]>
1ucian0
commented
Apr 19, 2024
qiskit/providers/provider.py
Outdated
| @deprecate_func( | ||
| since=1.1, | ||
| additional_msg="The abstract Provider and ProviderV1 classes are deprecated and will" | ||
| " be removed in 2.0. You can just remove it as the parent class and a `get_backend` method that returns the backends from `self.backend`.", |
There was a problem hiding this comment.
technically, there is no need to remove get_backend.
There was a problem hiding this comment.
Oh, I meant when you remove the parent class you should add get_backend back manually. The one method you get for free from the abstract class is get_backend so if people are dropping the abstract class as their parent they'll probably want to add that single method.
There was a problem hiding this comment.
oopss! I didnt read it properly, you are right.
mtreinish
previously approved these changes
Apr 22, 2024
mtreinish
approved these changes
Apr 23, 2024
github-merge-queue bot
pushed a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Apr 26, 2024
`Aer.get_backend()` was deprecated as part of the `Provider` abstract class deprecation in Qiskit/qiskit#12145. This PR replaces it with instantiating `AerSimulator()` directly so the cron CI tests can pass again. --------- Co-authored-by: Will Shanks <[email protected]>
1ucian0
added a commit
to 1ucian0/qiskit-terra
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The abstraction
Provider(andProviderV1) does not give you much:name,backends, and/orget_backend. That's it. And one of those (get_backend) is debatable in name.A provider is a collection of backends. Backend is the actual thing that Qiskit cares about. Providers are not structures that Qiskit handles around (like it used to Qiskit/qiskit-ibm-runtime#419), so there is no need to prescribe a specific API. Different providers have, for example, different credential handling. So having a different way to fetch a backend looks like minor to me. If you think the discussion is controversial enough, I could open a short RFC.
Details and comments
see also: #5629