-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating Provider ABC, as abstraction is not very useful #12145
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ef42417
Provider abstraction is not very useful
1ucian0 a30b8ec
udpate docs
1ucian0 2822a7d
ignore deprecations
1ucian0 26be87e
not triggered on CI
1ucian0 2462c08
deprecation warnings in visual tests
1ucian0 13dd0cd
set up
1ucian0 6c26b1f
set up without warning?
1ucian0 df178a3
setUpClass
1ucian0 a2e1f44
more test adjust
1ucian0 5c3a9fd
raise at setUpClass
1ucian0 d125803
warms
1ucian0 2af7adb
test_circuit_matplotlib_drawer.py
1ucian0 b03af73
skip Aer warning
1ucian0 afa1444
Apply suggestions from code review
1ucian0 0abdc2e
reno
1ucian0 d736053
Run black
mtreinish 038bc3c
Update release note
mtreinish 0128ea6
linter
1ucian0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply suggestions from code review
Co-authored-by: Matthew Treinish <[email protected]>
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, there is no need to remove
get_backend
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I meant when you remove the parent class you should add
get_backend
back manually. The one method you get for free from the abstract class isget_backend
so if people are dropping the abstract class as their parent they'll probably want to add that single method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oopss! I didnt read it properly, you are right.