Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Provider ABC (deprecated in 1.1) #13435

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Remove Provider ABC (deprecated in 1.1) #13435

wants to merge 10 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 13, 2024

Summary

Provider and ProviderV1 have been deprecated in #12145. This PR removes them.

@1ucian0 1ucian0 requested review from jyu00 and a team as code owners November 13, 2024 18:00
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 marked this pull request as draft November 13, 2024 19:00
@1ucian0 1ucian0 added this to the 2.0.0 milestone Nov 13, 2024
@1ucian0 1ucian0 changed the title Remove Provider ABC - deprecated in 1.1 Remove Provider ABC (deprecated in 1.1) Nov 13, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12274022852

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 88.938%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/providers/basic_provider/basic_provider.py 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 91.73%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 12261510589: -0.01%
Covered Lines: 79360
Relevant Lines: 89231
💛 - Coveralls

@1ucian0
Copy link
Member Author

1ucian0 commented Nov 18, 2024

Neko failure is blocked by the release of qiskit-community/qiskit-experiments#1490

@1ucian0 1ucian0 marked this pull request as ready for review November 18, 2024 14:00
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Dec 6, 2024
ElePT
ElePT reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but neko still shows that this removal breaks qiskit_experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT left review comments

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@1ucian0 @qiskit-bot @coveralls @ElePT