Enable a reduced set of pylint checks #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6163951208
💛 - Coveralls |
|
I think we should see what is left after #147 merges, then evaluate whether pylint catches enough that it is worth the extra time during the |
garrison
added a commit
that referenced
this pull request
Sep 12, 2023
This is something that pylint should have caught if we were using it (#146). This way, the tracebacks will say > The above exception was the direct cause of the following exception: rather than > During handling of the above exception, another exception occurred:
garrison
added a commit
that referenced
this pull request
Sep 12, 2023
This is something that pylint should have caught if we were using it (#146). This way, the tracebacks will say > The above exception was the direct cause of the following exception: rather than > During handling of the above exception, another exception occurred:
> circuit_knitting/cutting/cutqc/wire_cutting.py:226:4: W0622: Redefining built-in 'bin' (redefined-builtin)
caleb-johnson
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to see what would have to change in our code base to enable the same set of pylint checks that we've been using internally. Since pylint can be slow to execute, I've put it as the final check in the
lintworkflow intox.ini.I wonder if it would be possible to use ruff under nbqa. (EDIT: yes, see #147.) If it's possible, would it have caught most of these?
Opening for discussion, mainly.