Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI doesn't find unused function args #319

Closed
caleb-johnson opened this issue Jul 12, 2023 · 2 comments · Fixed by #419
Closed

CI doesn't find unused function args #319

caleb-johnson opened this issue Jul 12, 2023 · 2 comments · Fixed by #419
Assignees
@caleb-johnson
Labels
cicd Related to the CICD pipeline

Comments

@caleb-johnson
Copy link
Collaborator

caleb-johnson commented Jul 12, 2023 •
edited
Loading

CI does not seem to pick up unused function arguments.

I had two unused arguments to circuit_knitting.forging.efknitter._estimate_expvals in #307, and the style checks passed. The unused args have since been removed, but this should have been caught in CI.
@caleb-johnson caleb-johnson added the cicd Related to the CICD pipeline label Jul 12, 2023
@caleb-johnson
Copy link
Collaborator Author

I think ruff should catch this but checking now

@caleb-johnson caleb-johnson self-assigned this Jul 12, 2023
@garrison
Copy link
Member

I think ruff should catch this but checking now

If not, #146 should.

@garrison garrison mentioned this issue Sep 13, 2023
Merged
garrison added a commit that referenced this issue Sep 14, 2023
@garrison
Enable pylint's unused-argument check
02460f2 
Closes #319
@garrison garrison mentioned this issue Sep 14, 2023
Merged
garrison added a commit that referenced this issue Oct 4, 2023
@garrison
Enable pylint's unused-argument check (#419)
e58f786 
* Enable pylint's `unused-argument` check

Closes #319

* Remove unused `num_threads` argument from cutqc/serverless tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caleb-johnson caleb-johnson

Labels
cicd Related to the CICD pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable pylint's unused-argument check Qiskit/qiskit-addon-cutting
2 participants
@garrison @caleb-johnson