update translations from transifex #154

mcwhittemore · 2017-09-13T21:22:09Z

This is my first translation update. I think I did this right, but some 👀 would be nice.

1ec5 · 2017-09-13T21:24:30Z

languages/translations/de.json

-                "destination": "{modifier} weiterfahren Richtung {destination}"
+                "default": "Turn {modifier}",
+                "name": "Turn {modifier} to stay on {way_name}",
+                "destination": "Turn {modifier} towards {destination}",


Before we merge this, let’s go into Transifex and accept any 100% match suggestions so that perfectly acceptable translations don’t get overridden by the original English versions.

@1ec5 - I'm not sure how to do that

daniel-j-h

It looks like some German translation was ripped out for its English counterpart? Care to elaborate what's going on here?

daniel-j-h · 2017-09-14T08:35:55Z

languages/translations/de.json

-                "default": "{modifier} weiterfahren",
-                "name": "{modifier} weiterfahren auf {way_name}",
-                "destination": "{modifier} weiterfahren Richtung {destination}"
+                "default": "{modifier} abbiegen",


Does "abbiegen" make sense here? It basically means "to turn", but you can get a continue straight which we would then translate into "Geradeaus abbiegen" -> "turn straight" (?)

Sounds like we need a continue straight override like we've done here: https://github.com/Project-OSRM/osrm-text-instructions/blob/master/languages/translations/en.json#L93

daniel-j-h · 2017-09-14T08:36:35Z

languages/translations/de.json

-                "name": "{modifier} weiterfahren auf {way_name}",
-                "destination": "{modifier} weiterfahren Richtung {destination}"
+                "default": "{modifier} abbiegen",
+                "name": "Turn {modifier} to stay on {way_name}",


This is English still

daniel-j-h · 2017-09-14T08:36:54Z

languages/translations/de.json

+            },
+            "sharp left": {
+                "default": "Scharf links",
+                "name": "Make a sharp left to stay on {way_name}",


Still English

daniel-j-h · 2017-09-14T08:38:30Z

languages/translations/de.json

+            "sharp left": {
+                "default": "Scharf links",
+                "name": "Make a sharp left to stay on {way_name}",
+                "destination": "Scharf links Richtung {destination}"


Here and below: this feels a bit too short, it's basically

"Sharp right towards"

daniel-j-h · 2017-09-14T08:39:44Z

languages/translations/de.json

-                "default": "{modifier} weiterfahren",
-                "name": "{modifier} weiterfahren auf {way_name}",
-                "destination": "{modifier} weiterfahren Richtung {destination}"
+                "default": "{modifier} abbiegen",


Here and below: for all the continue maneuvers I think we should highlight that the road actually continues.

daniel-j-h · 2017-09-14T08:40:07Z

languages/translations/de.json

-                "name": "Leicht links weiter auf {way_name}",
-                "destination": "Leicht links weiter Richtung {destination}"
+                "default": "Scharf links",
+                "name": "Make a slight left to stay on {way_name}",


Here and below: English still in here

davols · 2017-09-14T11:40:55Z

languages/translations/sv.json

-                "default": "Fortsätt åt vänster",
-                "name": "Fortsätt åt vänster in på {way_name}",
-                "destination": "Fortsätt åt vänster mot {destination}"
+                "default": "Make a slight left",


Same here, english. several of the continue has a history of having a translation previously. But now they are empty and untranslated.

davols · 2017-09-14T14:09:13Z

Swedish has been updated. Both the new not previously used strings are translated and also the ones that disappeared for some reason in Transifex.

Would assume that fixes the comment I made.
Latest commit was as of this writing 7min ago - And I just finished fixing the last Swedish bits.

Please check if there are any changes to have Swedish in this PR, or I could make my own PR for Swedish specifically.

ping @frederoni for some extra eyes

mcwhittemore · 2017-09-14T14:16:12Z

@davols - Thanks for the heads up.

I've pulled from Transifex again and then ran a script to compare the post Transifex version of the translations with the English translation. Where the non-english and english matched up, I reset the value to what is currently in master. I think this should mean that the leaking of English has been fixed up. I'm scrolling through the changes now to confirm.

revert to old values where new values match english

mcwhittemore · 2017-09-14T14:24:01Z

It looks like some German translation was ripped out for its English counterpart? Care to elaborate what's going on here?

I'm not 100% sure why this has happened. @1ec5 mentioned that this is partial because we blindly pull files down from Transifex and that if we used the tx cli tool this would be less likely to happen.

Thanks for your eyes @davols and @daniel-j-h. If I can get one last review, I think we can merge this.

daniel-j-h · 2017-09-14T14:26:36Z

languages/translations/de.json

                "name": "{modifier} weiterfahren auf {way_name}",
-                "destination": "{modifier} weiterfahren Richtung {destination}"
+                "destination": "{modifier} abbiegen Richtung {destination}"


Why did we change from "weiterfahren" (continue) here to "abbiegen" (turn) for the continue instruction?

So, most of the continue maneuvers require you to make a turn so we changed the default to use turn and then created an override for straight to say continue. I'm guess that the translator saw this change in english and made it here, but didn't provide straight override.

daniel-j-h · 2017-09-14T14:27:06Z

languages/translations/de.json

            },
            "slight left": {
-                "default": "Leicht links weiter",
+                "default": "Scharf links",


slight left should be "Leicht links" - Scharf means sharp, maybe a mixup in the translations

frederoni · 2017-09-14T14:46:15Z

test/fixtures/v5/continue/left_exit.json

        "nl": "Ga links naar Way Name",
        "pl": "Kontynuuj lewo na Way Name",
        "pt-BR": "Continue à esquerda em Way Name",
        "ru": "Двигайтесь налево по Way Name",
-        "sv": "Fortsätt vänster in på Way Name",
+        "sv": "Sväng vänsteroch fortsätt på Way Name",


missing whitespace (fixed in Transifex) /cc @davols

1ec5 · 2017-09-14T15:50:25Z

Regarding the English strings creeping in, this is unfortunately quite normal for translation systems. Whenever a base string (in English for this project) changes, all the translations of that string are “dirtied” in Transifex, so translators need to go in and update the translations. For minor changes like “Take a sharp left” → “Make a sharp left”, this should just be a matter of accepting the closest-matching suggestion. Meanwhile, any updates to this project will cause an English string to be substituted for the dirtied string, because outdated strings can be problematic (consider a change that adds or removes a placeholder token).

Replacing our ad-hoc tool with tx (#94) will help somewhat, as it would give us options for skipping a resource that’s inadequately translated according to Transifex. Choosing a different message format (#19) would help by giving us the ability to break up en.json into multiple resources, minimizing the disruption caused by changes to one resource.

mcwhittemore requested a review from 1ec5 September 13, 2017 21:23

1ec5 reviewed Sep 13, 2017

View reviewed changes

mcwhittemore force-pushed the translate branch from 5a0ef86 to ca8b065 Compare September 13, 2017 22:22

1ec5 mentioned this pull request Sep 13, 2017

Improving Swedish translation (Exit numbers, overrides, modifiers and roundabouts and questions) #136

Closed

daniel-j-h requested changes Sep 14, 2017

View reviewed changes

davols reviewed Sep 14, 2017

View reviewed changes

mcwhittemore force-pushed the translate branch from aa55003 to a1194db Compare September 14, 2017 14:08

mcwhittemore force-pushed the translate branch 2 times, most recently from 258dc07 to 239cecb Compare September 14, 2017 14:11

mcwhittemore added 2 commits September 14, 2017 10:18

update translations from transifex

efae142

revert to old values where new values match english

update all the tests

c6cec58

mcwhittemore force-pushed the translate branch from 239cecb to c6cec58 Compare September 14, 2017 14:18

daniel-j-h requested changes Sep 14, 2017

View reviewed changes

frederoni reviewed Sep 14, 2017

View reviewed changes

pull DE and SV from transifex

f8d32ce

mcwhittemore added 2 commits September 14, 2017 11:57

update tests after updating de and sv

03abc5a

one more attempt to pull in updates

d43cc6f

mcwhittemore merged commit e04dc23 into master Sep 14, 2017

mcwhittemore deleted the translate branch September 14, 2017 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update translations from transifex #154

update translations from transifex #154

mcwhittemore commented Sep 13, 2017

1ec5 Sep 13, 2017

mcwhittemore Sep 13, 2017

daniel-j-h left a comment

daniel-j-h Sep 14, 2017

mcwhittemore Sep 14, 2017

daniel-j-h Sep 14, 2017

daniel-j-h Sep 14, 2017

daniel-j-h Sep 14, 2017

daniel-j-h Sep 14, 2017

daniel-j-h Sep 14, 2017

davols Sep 14, 2017

davols commented Sep 14, 2017

mcwhittemore commented Sep 14, 2017

mcwhittemore commented Sep 14, 2017

daniel-j-h Sep 14, 2017

mcwhittemore Sep 14, 2017 •

edited

Loading

daniel-j-h Sep 14, 2017

frederoni Sep 14, 2017 •

edited

Loading

1ec5 commented Sep 14, 2017

update translations from transifex #154

update translations from transifex #154

Conversation

mcwhittemore commented Sep 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-j-h left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davols commented Sep 14, 2017

mcwhittemore commented Sep 14, 2017

mcwhittemore commented Sep 14, 2017

Choose a reason for hiding this comment

mcwhittemore Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frederoni Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

1ec5 commented Sep 14, 2017

mcwhittemore Sep 14, 2017 •

edited

Loading

frederoni Sep 14, 2017 •

edited

Loading