Drop support of Node 12 & 14 #6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
force-pushed
the
sf-node-12-remove
branch
from
d4eeeeb to
bc05029
Compare
| @@ -449,53 +463,6 @@ jobs: | |||
| ENABLE_CONAN: ON | |||
| NODE_PACKAGE_TESTS_ONLY: ON | |||
|
|
|||
| - name: conan-macos-x64-release-node-lts | |||
There was a problem hiding this comment.
LTS is Node 18 at the moment, i.e. it seems there is no reason to build it separately as we explicitly build Node 18 version now.
There was a problem hiding this comment.
Just for better understanding: node-latest is Node 19 now.
| runs-on: ubuntu-20.04 | ||
| BUILD_TYPE: Debug | ||
| CCOMPILER: clang-6.0 | ||
| CXXCOMPILER: clang++-6.0 | ||
| ENABLE_CONAN: ON | ||
| NODE_PACKAGE_TESTS_ONLY: ON | ||
|
|
||
|
|
||
| - name: node-16-conan-linux-release |
There was a problem hiding this comment.
We removed Node 12 jobs, but added Node 18 instead(which we implicitly had before, but named it "LTS")
SiarheiFedartsou
force-pushed
the
sf-node-12-remove
branch
from
bc05029 to
732d2f8
Compare
SiarheiFedartsou
changed the title
mattwigway
pushed a commit
to mattwigway/osrm-backend
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is no even security support for Node 12 now and 14 will meet end of life in 6 months https://endoflife.date/nodejs
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?