Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of Node 12 & 14 #6431

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Drop support of Node 12 & 14 #6431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
732d2f8
Drop support of Node 12 & 14
SiarheiFedartsou Oct 31, 2022
175e9e8
Drop support of Node 12 & 14
SiarheiFedartsou Oct 31, 2022
537414c
Drop support of Node 12 & 14
SiarheiFedartsou Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 33 additions & 102 deletions .github/workflows/osrm-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ jobs:
format-taginfo-docs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 12
node-version: 16
- name: Enable Node.js cache
uses: actions/cache@v3
with:
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:
include:
- name: gcc-9-debug-cov
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
Expand All @@ -157,7 +157,7 @@ jobs:

- name: gcc-9-debug-asan-ubsan
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
Expand All @@ -171,7 +171,7 @@ jobs:

- name: clang-6.0-debug
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
Expand All @@ -181,7 +181,7 @@ jobs:

- name: clang-11.0-debug-clang-tidy
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-22.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
Expand All @@ -192,7 +192,7 @@ jobs:

- name: conan-linux-debug-asan-ubsan
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -203,7 +203,7 @@ jobs:

- name: conan-linux-release
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -213,7 +213,7 @@ jobs:

- name: gcc-11-release
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -223,7 +223,7 @@ jobs:

- name: gcc-10-release
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -232,7 +232,7 @@ jobs:

- name: gcc-9-release
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -242,7 +242,7 @@ jobs:

- name: gcc-9-conan-release-i686
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -255,7 +255,7 @@ jobs:

- name: gcc-8-release
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -265,17 +265,17 @@ jobs:

- name: gcc-7-release
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
CCOMPILER: gcc-7
CXXCOMPILER: g++-7

- name: conan-macos-x64-release-node-12
- name: conan-macos-x64-release-node-16
build_node_package: true
continue-on-error: false
node: 12
node: 16
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -285,10 +285,10 @@ jobs:
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-x64-release-node-14
- name: conan-macos-arm64-release-node-16
build_node_package: true
continue-on-error: false
node: 14
node: 16
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -297,11 +297,12 @@ jobs:
CUCUMBER_TIMEOUT: 60000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON
ENABLE_APPLE_SILICON: ON

- name: conan-macos-x64-release-node-16
- name: conan-macos-x64-release-node-18
build_node_package: true
continue-on-error: false
node: 16
node: 18
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -311,10 +312,10 @@ jobs:
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-arm64-release-node-16
- name: conan-macos-arm64-release-node-18
build_node_package: true
continue-on-error: false
node: 16
node: 18
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
Expand All @@ -327,74 +328,51 @@ jobs:

- name: gcc-7-release-shared
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
BUILD_SHARED_LIBS: ON
CCOMPILER: gcc-7
CXXCOMPILER: g++-7

- name: node-12-conan-linux-release
- name: node-16-conan-linux-release
build_node_package: true
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-12-conan-linux-debug
- name: node-16-conan-linux-debug
build_node_package: true
continue-on-error: false
node: 12
node: 16
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-14-conan-linux-release
- name: node-18-conan-linux-release
build_node_package: true
continue-on-error: false
node: 14
node: 18
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-14-conan-linux-debug
- name: node-18-conan-linux-debug
build_node_package: true
continue-on-error: false
node: 14
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON


- name: node-16-conan-linux-release
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed Node 12 jobs, but added Node 18 instead(which we implicitly had before, but named it "LTS")

build_node_package: true
continue-on-error: false
node: 16
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-16-conan-linux-debug
build_node_package: true
continue-on-error: false
node: 16
node: 18
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
Expand Down Expand Up @@ -449,53 +427,6 @@ jobs:
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: conan-macos-x64-release-node-lts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTS is Node 18 at the moment, i.e. it seems there is no reason to build it separately as we explicitly build Node 18 version now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for better understanding: node-latest is Node 19 now.

build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: macos-11
BUILD_TYPE: Release
CCOMPILER: clang
CXXCOMPILER: clang++
CUCUMBER_TIMEOUT: 60000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-arm64-release-node-lts
build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: macos-11
BUILD_TYPE: Release
CCOMPILER: clang
CXXCOMPILER: clang++
CUCUMBER_TIMEOUT: 60000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON
ENABLE_APPLE_SILICON: ON

- name: node-lts-conan-linux-release
build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-lts-conan-linux-debug
build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

name: ${{ matrix.name}}
continue-on-error: ${{ matrix.continue-on-error }}
runs-on: ${{ matrix.runs-on }}
Expand All @@ -519,7 +450,7 @@ jobs:
OSRM_CONNECTION_RETRIES: ${{ matrix.OSRM_CONNECTION_RETRIES }}
OSRM_CONNECTION_EXP_BACKOFF_COEF: ${{ matrix.OSRM_CONNECTION_EXP_BACKOFF_COEF }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Use Node.js
uses: actions/setup-node@v3
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- Changes from 5.27.1
- Build:
- CHANGED: Update actions/cache to v3. [#6420](https://github.com/Project-OSRM/osrm-backend/pull/6420)
- REMOVED: Drop support of Node 12 & 14. [#6431](https://github.com/Project-OSRM/osrm-backend/pull/6431)
- Misc:
- FIXED: Handle snapping parameter for all plugins in NodeJs bindings, but not for Route only. [#6417](https://github.com/Project-OSRM/osrm-backend/pull/6417)
- FIXED: Fix annotations=true handling in NodeJS bindings & libosrm. [#6415](https://github.com/Project-OSRM/osrm-backend/pull/6415/)
Expand Down
Loading