Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop support of Node 12
Browse files Browse the repository at this point in the history
SiarheiFedartsou committed Oct 30, 2022
1 parent 16685d0 commit bc05029
Showing 2 changed files with 49 additions and 81 deletions.
129 changes: 48 additions & 81 deletions .github/workflows/osrm-backend.yml
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v3
with:
node-version: 12
node-version: 14
- name: Enable Node.js cache
uses: actions/cache@v3
with:
@@ -146,7 +146,7 @@ jobs:
include:
- name: gcc-9-debug-cov
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
@@ -157,7 +157,7 @@ jobs:

- name: gcc-9-debug-asan-ubsan
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
@@ -171,7 +171,7 @@ jobs:

- name: clang-6.0-debug
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
@@ -181,7 +181,7 @@ jobs:

- name: clang-11.0-debug-clang-tidy
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-22.04
BUILD_TOOLS: ON
BUILD_TYPE: Debug
@@ -192,7 +192,7 @@ jobs:

- name: conan-linux-debug-asan-ubsan
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -203,7 +203,7 @@ jobs:

- name: conan-linux-release
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -213,7 +213,7 @@ jobs:

- name: gcc-11-release
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -223,7 +223,7 @@ jobs:

- name: gcc-10-release
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -232,7 +232,7 @@ jobs:

- name: gcc-9-release
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -242,7 +242,7 @@ jobs:

- name: gcc-9-conan-release-i686
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -255,7 +255,7 @@ jobs:

- name: gcc-8-release
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -265,17 +265,17 @@ jobs:

- name: gcc-7-release
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
CCOMPILER: gcc-7
CXXCOMPILER: g++-7

- name: conan-macos-x64-release-node-12
- name: conan-macos-x64-release-node-14
build_node_package: true
continue-on-error: false
node: 12
node: 14
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -285,10 +285,10 @@ jobs:
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-x64-release-node-14
- name: conan-macos-x64-release-node-16
build_node_package: true
continue-on-error: false
node: 14
node: 16
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -298,7 +298,7 @@ jobs:
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-x64-release-node-16
- name: conan-macos-arm64-release-node-16
build_node_package: true
continue-on-error: false
node: 16
@@ -310,11 +310,25 @@ jobs:
CUCUMBER_TIMEOUT: 60000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON
ENABLE_APPLE_SILICON: ON

- name: conan-macos-arm64-release-node-16
- name: conan-macos-x64-release-node-18
build_node_package: true
continue-on-error: false
node: 16
node: 18
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
CCOMPILER: clang
CXXCOMPILER: clang++
CUCUMBER_TIMEOUT: 60000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-arm64-release-node-18
build_node_package: true
continue-on-error: false
node: 18
runs-on: macos-11
BUILD_TOOLS: ON
BUILD_TYPE: Release
@@ -327,74 +341,74 @@ jobs:

- name: gcc-7-release-shared
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TOOLS: ON
BUILD_TYPE: Release
BUILD_SHARED_LIBS: ON
CCOMPILER: gcc-7
CXXCOMPILER: g++-7

- name: node-12-conan-linux-release
- name: node-14-conan-linux-release
build_node_package: true
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-12-conan-linux-debug
- name: node-14-conan-linux-debug
build_node_package: true
continue-on-error: false
node: 12
node: 14
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-14-conan-linux-release

- name: node-16-conan-linux-release
build_node_package: true
continue-on-error: false
node: 14
node: 16
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-14-conan-linux-debug
- name: node-16-conan-linux-debug
build_node_package: true
continue-on-error: false
node: 14
node: 16
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON


- name: node-16-conan-linux-release
- name: node-18-conan-linux-release
build_node_package: true
continue-on-error: false
node: 16
node: 18
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-16-conan-linux-debug
- name: node-18-conan-linux-debug
build_node_package: true
continue-on-error: false
node: 16
node: 18
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
@@ -449,53 +463,6 @@ jobs:
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: conan-macos-x64-release-node-lts
build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: macos-11
BUILD_TYPE: Release
CCOMPILER: clang
CXXCOMPILER: clang++
CUCUMBER_TIMEOUT: 60000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-arm64-release-node-lts
build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: macos-11
BUILD_TYPE: Release
CCOMPILER: clang
CXXCOMPILER: clang++
CUCUMBER_TIMEOUT: 60000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON
ENABLE_APPLE_SILICON: ON

- name: node-lts-conan-linux-release
build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: ubuntu-20.04
BUILD_TYPE: Release
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: node-lts-conan-linux-debug
build_node_package: true
continue-on-error: true
node: "lts/*"
runs-on: ubuntu-20.04
BUILD_TYPE: Debug
CCOMPILER: clang-6.0
CXXCOMPILER: clang++-6.0
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

name: ${{ matrix.name}}
continue-on-error: ${{ matrix.continue-on-error }}
runs-on: ${{ matrix.runs-on }}
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@
- Changes from 5.27.1
- Build:
- CHANGED: Update actions/cache to v3. [#6420](https://github.com/Project-OSRM/osrm-backend/pull/6420)
- REMOVED: Drop support of Node 12. [#6431](https://github.com/Project-OSRM/osrm-backend/pull/6431)
- Misc:
- FIXED: Handle snapping parameter for all plugins in NodeJs bindings, but not for Route only. [#6417](https://github.com/Project-OSRM/osrm-backend/pull/6417)
- FIXED: Fix annotations=true handling in NodeJS bindings & libosrm. [#6415](https://github.com/Project-OSRM/osrm-backend/pull/6415/)

0 comments on commit bc05029

Please sign in to comment.