Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes schema, add bedrock data #692

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

extremeheat
Copy link
Member

  • adds min, max and default values to attributes, from source code
  • remove minecraft: prefix in 1.16/1.17 pc "resource" names to match vanilla and the other versions' data
  • add bedrock data for attributes
  • rename armor -> armorHealth in pc's name for clarity

@extremeheat
Copy link
Member Author

Manually generated from script. Attributes haven't changed since 1.9 (adding luck), so less chance of breakage in future versions

@extremeheat extremeheat requested a review from u9g March 3, 2023 03:52
@rom1504
Copy link
Member

rom1504 commented Mar 4, 2023

can you say how this must be updated in new version file ?

@rom1504
Copy link
Member

rom1504 commented Jun 3, 2023

@extremeheat should we merge this?

Copy link
Member

@u9g u9g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine given its generated using a script, is there any chance this can be added to the data extractor?

@extremeheat
Copy link
Member Author

@extremeheat should we merge this?

Ready for merge

This looks fine given its generated using a script, is there any chance this can be added to the data extractor?

Yeah, likewise for #710 and #695 I think these scripts that operate on the mc source code could go into a new repo or maybe jar-extractor with a refactor. Another option is to repurpose https://github.com/PrismarineJS/minecraft-data-auto-updater as a package that can do this kind of extraction

@rom1504
Copy link
Member

rom1504 commented Jun 11, 2023

@rom1504 rom1504 merged commit fa4c64e into PrismarineJS:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants