-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pc: add entity metadata #710
Conversation
Adds entity metadata keys to entities.json for pc, updates protocol.json to use string mapping for metadata values
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
@@ -0,0 +1,153 @@ | |||
const fs = require('fs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather we have a dedicated package for extraction. tools/js should not contain large amount of code as it's not documented and generally not maintained.
where would that kind of extraction fit? what's the source of data ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I didn't know where else to put it so I left it in here for now.
It basically clones a copy of the mc source code and then does some string manipulation to extract the relevant information from the human readable source code files. Then updates the files in mc-data.
http://github.com/prismarinejs/mcdataextracting requires a fabric mode and Java code injection
http://github.com/prismarinejs/minecraft-jar-extractor is a better fit, but would need some refactoring to use mojang mappings and the ForgeFlower decompiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I was not saying reimplement it another way, just move it elsewhere
maybe it could just be put in minecraft-jar-extractor with no change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but let's not block on that, can be done in another pr
Adds entity metadata keys to entities.json for pc, updates protocol.json to use string mapping for metadata item values
Addresses #72 a bit