Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc: add entity metadata #710

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Conversation

extremeheat
Copy link
Member

@extremeheat extremeheat commented Jun 5, 2023

Adds entity metadata keys to entities.json for pc, updates protocol.json to use string mapping for metadata item values

Addresses #72 a bit

Adds entity metadata keys to entities.json for pc, updates protocol.json to use string mapping for metadata values
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +18 isaacs
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
[email protected] 5.2.0...10.2.0 shell +44/-10 juergba

@extremeheat extremeheat marked this pull request as draft June 5, 2023 11:57
@extremeheat extremeheat marked this pull request as ready for review June 5, 2023 12:12
@@ -0,0 +1,153 @@
const fs = require('fs')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we have a dedicated package for extraction. tools/js should not contain large amount of code as it's not documented and generally not maintained.

where would that kind of extraction fit? what's the source of data ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't know where else to put it so I left it in here for now.

It basically clones a copy of the mc source code and then does some string manipulation to extract the relevant information from the human readable source code files. Then updates the files in mc-data.

http://github.com/prismarinejs/mcdataextracting requires a fabric mode and Java code injection
http://github.com/prismarinejs/minecraft-jar-extractor is a better fit, but would need some refactoring to use mojang mappings and the ForgeFlower decompiler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I was not saying reimplement it another way, just move it elsewhere

maybe it could just be put in minecraft-jar-extractor with no change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but let's not block on that, can be done in another pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants