Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use our own session recording player #2470

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Use our own session recording player #2470

merged 5 commits into from
Nov 23, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Nov 23, 2020 •
edited
Loading

Changes

How this looks like:

Screenshot from 2020-11-23 14-20-10

This resolves some tickets like:

New functionalities:

  • Keyboard navigation: Space to pause/unpause, f for fullscreen, forward and back for skipping a few seconds
  • Back N seconds button
  • Next/previous recording buttons
  • Full screen which does not lose player controls
  • Overlay when skipping inactive
  • Animations for play/pause
  • Dynamic player sizing
  • 16x speed

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@macobo macobo requested a review from paolodamico November 23, 2020 12:25
@timgl timgl temporarily deployed to posthog-new-session-rec-ibkrlc November 23, 2020 12:26 Inactive
paolodamico
paolodamico reviewed Nov 23, 2020
View reviewed changes
yarn.lock Outdated
@@ -7488,6 +7512,13 @@ react-hot-loader@^4.12.21:
shallowequal "^1.1.0"
source-map "^0.7.3"

react-icons@^3.11.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dep should be removed with the new version bump, right?

@macobo macobo force-pushed the new-session-recording-player branch from b0c77a2 to 933a442 Compare November 23, 2020 14:01
@macobo macobo temporarily deployed to posthog-new-session-rec-ibkrlc November 23, 2020 14:02 Inactive
paolodamico
paolodamico approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paolodamico paolodamico merged commit 7a0ba0a into master Nov 23, 2020
@paolodamico paolodamico deleted the new-session-recording-player branch November 23, 2020 14:08
paolodamico added a commit that referenced this pull request Nov 23, 2020
@paolodamico
Revert "Use our own session recording player (#2470)"
c9864d8 
This reverts commit 7a0ba0a.
@paolodamico paolodamico mentioned this pull request Nov 23, 2020
Merged
paolodamico added a commit that referenced this pull request Nov 23, 2020
@paolodamico
Revert "Use our own session recording player (#2470)" (#2477)
c601024
macobo added a commit that referenced this pull request Nov 24, 2020
@macobo
Revert "Revert "Use our own session recording player (#2470)" (#2477)"
09f75aa 
This reverts commit c601024.
macobo added a commit that referenced this pull request Nov 25, 2020
@macobo
Use our own session recording player (Revert-revert) (#2491)
8fe26f3 
* Revert "Revert "Use our own session recording player (#2470)" (#2477)"

This reverts commit c601024.

* Update player package

* Explicitly include rrweb styles

It seems like our package isn't bundling them properly - this should fix
things.

* Manage session player css via scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macobo @paolodamico @timgl