Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use our own session recording player" #2477

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

paolodamico
Copy link
Contributor

Reverts #2470 because it broke the session recording player (just a gray screen is shown with only the mouse movements).

Additional context: On slack.
Sentry errors: 2050495524, 2025848487, 2050407503.

@paolodamico paolodamico requested a review from Twixes November 23, 2020 18:12
@timgl timgl temporarily deployed to posthog-revert-2470-new-wk4iqa November 23, 2020 18:12 Inactive
@paolodamico paolodamico merged commit c601024 into master Nov 23, 2020
@paolodamico paolodamico deleted the revert-2470-new-session-recording-player branch November 23, 2020 18:22
macobo added a commit that referenced this pull request Nov 24, 2020
macobo added a commit that referenced this pull request Nov 25, 2020
* Revert "Revert "Use our own session recording player (#2470)" (#2477)"

This reverts commit c601024.

* Update player package

* Explicitly include rrweb styles

It seems like our package isn't bundling them properly - this should fix
things.

* Manage session player css via scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants