Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): tbd #13622

Closed
wants to merge 17 commits into from
Closed

fix(storybook): tbd #13622

wants to merge 17 commits into from

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jan 10, 2023

Problem

  1. apt-get fails on github actions, see Unable to connect to azure.archive.ubuntu.com flaky failure on ubuntu-latest actions/runner-images#675, Unable to connect to azure.archive.ubuntu.com flaky failure on ubuntu-* strikes back actions/runner-images#6894
  2. we don't know which git commit is deployed to storybook
  3. https://github.com/PostHog/posthog/pull/13582/files broke storybook, see https://storybook.posthog.net/?path=/story/scenes-app-insights--trends-line
  4. a visual regression test that is failing

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@thmsobrmlr thmsobrmlr force-pushed the fix-storybook-build branch 3 times, most recently from e1fe6d7 to 9e376c9 Compare January 10, 2023 21:02
@thmsobrmlr thmsobrmlr closed this Jan 12, 2023
@thmsobrmlr thmsobrmlr deleted the fix-storybook-build branch January 12, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant