fix(demo): allow regular org members to create demo proj #13582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kappa90
suggested changes
Jan 5, 2023
| subtext="Explore insights, create dashboards, try out cohorts, and more." | ||
| /> | ||
| ) : null} | ||
| <DemoProjectButton |
There was a problem hiding this comment.
Shouldn't this be behind the new flag you created?
There was a problem hiding this comment.
I put the check inside that component since it was implemented in a couple different places. https://github.com/PostHog/posthog/pull/13582/files#diff-b45ab9c675aae471e2211c373c0d3bbdb6faaf7f6db73d1a9e72594863f1744eR74
kappa90
approved these changes
Jan 6, 2023
thmsobrmlr
added a commit
that referenced
this pull request
Jan 10, 2023
)" This reverts commit 0c1ff71.
thmsobrmlr
added a commit
that referenced
this pull request
Jan 10, 2023
)" This reverts commit 0c1ff71.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Only admins were allowed to create demo projects. Should allow anyone in the org to do so.
Changes
This first reverts the revert in da3af1c. So you only need to review changes from then on.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Added a test to make sure regular members can create a demo team