Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): tbd #13622

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci-e2e-vrt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ jobs:
- name: Build Storybook
run: pnpm build-storybook --quiet

- name: Update apt-get
run: sudo apt update && sudo apt upgrade -y

- name: Install Playwright Browsers
run: pnpm exec playwright install --with-deps

Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/storybook-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- master
- main
- fix-storybook-build

jobs:
storybook-deployment:
Expand Down Expand Up @@ -49,11 +50,15 @@ jobs:
rm -rf storybook-build/docs
cp -a posthog/storybook-static storybook-build/docs

- name: Set commit message
id: commit-message
run: echo "msg=Storybook build for ${{ github.sha }}" >> $GITHUB_OUTPUT

- name: Commit update
uses: stefanzweifel/git-auto-commit-action@v4
with:
repository: storybook-build
commit_message: 'Storybook build'
commit_message: ${{ steps.commit-message.outputs.msg }}
commit_user_name: PostHog Bot
commit_user_email: [email protected]
commit_author: PostHog Bot <[email protected]>
22 changes: 11 additions & 11 deletions frontend/src/scenes/ingestion/v2/ingestionLogicV2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -535,17 +535,17 @@ export const ingestionLogicV2 = kea<ingestionLogicV2Type>([
}
},
createTeamSuccess: ({ currentTeam }) => {
if (window.location.href.includes(urls.ingestion()) && currentTeam.is_demo) {
const interval = window.setInterval(async () => {
const res = await api.get('api/projects/@current/is_generating_demo_data')
if (!res.is_generating_demo_data) {
actions.setIsDemoDataReady(true)
}
}, 1000)
actions.setDemoDataInterval(interval)
} else {
window.location.href = urls.ingestion()
}
// if (window.location.href.includes(urls.ingestion()) && currentTeam.is_demo) {
// const interval = window.setInterval(async () => {
// const res = await api.get('api/projects/@current/is_generating_demo_data')
// if (!res.is_generating_demo_data) {
// actions.setIsDemoDataReady(true)
// }
// }, 1000)
// actions.setDemoDataInterval(interval)
// } else {
// window.location.href = urls.ingestion()
// }
},
setIsDemoDataReady: ({ isDemoDataReady }) => {
if (isDemoDataReady) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export function DemoProjectButton({ text, subtext }: { text: string; subtext?: s
if (featureFlags[FEATURE_FLAGS.ONBOARDING_V2_DEMO] !== 'test') {
return <></>
}

return (
<LemonButton
onClick={() => {
Expand Down
8 changes: 4 additions & 4 deletions playwright/e2e-vrt/components/PropertiesTimeline.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ test.describe('Properties Timeline', () => {
await storyPage.expectComponentScreenshot()
})

test('No Points for No Person Properties', async ({ storyPage }) => {
await storyPage.goto(toId('Components/Properties Timeline', 'No Points for No Person Properties'))
await storyPage.expectComponentScreenshot()
})
// test('No Points for No Person Properties', async ({ storyPage }) => {
// await storyPage.goto(toId('Components/Properties Timeline', 'No Points for No Person Properties'))
// await storyPage.expectComponentScreenshot()
// })
})