-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FollowPath: implement path_mode=single and loitering #4660
Conversation
@janpascal, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alexyaoyang, @binarydepartment and @JaapMoolenaar to be potential reviewers |
This is a great feature which makes the bot more humanized! 👍 Just a few suggestions:
|
loiter work with .gpx files. How to configure please? |
@erdnaxela02 : gpx files are usually automatically generated, e.g. by a GPS device or tracking software on a mobile phone. If you like the loiter option, I think you should extract the waypoint from the gpx and put them in a json, and add the loiter values by hand. |
@alexyaoyang: I've added the documentation you asked for, could you please have another look? |
Looks good to me! Merging this as feature does not affect current behavior. |
@janpascal A quick test would be great next time! Good job on this feature tho! I can see myself using it! 👍 |
Short Description:
Add two features to FollowPath:
Fixes/Resolves/Closes (please use correct syntax):