Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FollowPath: implement path_mode=single and loitering #4660

Merged
merged 4 commits into from
Aug 24, 2016

Conversation

janpascal
Copy link
Contributor

@janpascal janpascal commented Aug 24, 2016

Short Description:

Add two features to FollowPath:

  • path_mode: 'single' will follow the path only once
  • 'loiter' in the json file will cause the bot pause following the path for a while, and instead execute the next task. E.g. if a MoveToFort task is next, the bot will chase pokestops for the indicated number of seconds, and the resume the path

Fixes/Resolves/Closes (please use correct syntax):

@mention-bot
Copy link

@janpascal, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alexyaoyang, @binarydepartment and @JaapMoolenaar to be potential reviewers

@alexyaoyang
Copy link
Contributor

alexyaoyang commented Aug 24, 2016

This is a great feature which makes the bot more humanized! 👍

Just a few suggestions:

  • Can you update the path.json.example to include your latest update?
  • Maybe tell the users clearly and explicitly in configurations.md that they need to have other Move tasks in their task list or else the bot will not move at all after a single run on single mode or during loiter? I'm not sure if everyone has MoveToFort in their task list and some peeps that don't might be wondering why their bot is standing still instead of loitering.

@casse-boubou
Copy link

loiter work with .gpx files. How to configure please?
Thanks

@janpascal
Copy link
Contributor Author

@erdnaxela02 : gpx files are usually automatically generated, e.g. by a GPS device or tracking software on a mobile phone. If you like the loiter option, I think you should extract the waypoint from the gpx and put them in a json, and add the loiter values by hand.

@janpascal
Copy link
Contributor Author

@alexyaoyang: I've added the documentation you asked for, could you please have another look?

@alexyaoyang
Copy link
Contributor

Looks good to me! Merging this as feature does not affect current behavior.

@alexyaoyang alexyaoyang merged commit c3039fb into PokemonGoF:dev Aug 24, 2016
@alexyaoyang
Copy link
Contributor

alexyaoyang commented Aug 24, 2016

@janpascal A quick test would be great next time! Good job on this feature tho! I can see myself using it! 👍

@alexyaoyang alexyaoyang mentioned this pull request Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants