Introduce SuggestedFixRules Refaster rule collection
#559
Conversation
|
Looks good. No mutations were possible for these changes. |
| static final class SuggestedFixReplaceTree { | ||
| @BeforeTemplate | ||
| SuggestedFix before(Tree tree, String replaceWith) { | ||
| return SuggestedFix.builder().replace(tree, replaceWith).build(); |
There was a problem hiding this comment.
I'm curious why the replaceWith part is left out in all titles 👀.
There was a problem hiding this comment.
Because I started out with a name that didn't include it, I think.
| } | ||
|
|
||
| /** Prefer {@link SuggestedFix#swap(Tree, Tree)} over more contrived alternatives. */ | ||
| static final class SuggestedFixSwap { |
There was a problem hiding this comment.
What order do we use here? Should we use the same order as the methods are listed in SuggestedFix?
There was a problem hiding this comment.
Long-term I guess lexicographical order makes most sense. Here I went with "likelihood of being used".
| } | ||
|
|
||
| /** Prefer {@link SuggestedFix#swap(Tree, Tree)} over more contrived alternatives. */ | ||
| static final class SuggestedFixSwap { |
There was a problem hiding this comment.
What order do we use here? Should we use the same order as the methods are listed in SuggestedFix?
| SuggestedFix after(Tree tree, String postfix) { | ||
| return SuggestedFix.postfixWith(tree, postfix); | ||
| } | ||
| } |
There was a problem hiding this comment.
Any reason for omitting SuggestedFix#delete(Tree)? I added it :).
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
sschroevers/refaster-suggestedfix
branch
from
cacc84b to
e7b47a7
Compare
| } | ||
|
|
||
| SuggestedFix testSuggestedFixDelete() { | ||
| return SuggestedFix.builder().delete((Tree) null).build(); |
There was a problem hiding this comment.
No need to cast here. (Another thing we could try to auto-fix.)
| static final class SuggestedFixReplaceTree { | ||
| @BeforeTemplate | ||
| SuggestedFix before(Tree tree, String replaceWith) { | ||
| return SuggestedFix.builder().replace(tree, replaceWith).build(); |
There was a problem hiding this comment.
Because I started out with a name that didn't include it, I think.
| } | ||
|
|
||
| /** Prefer {@link SuggestedFix#swap(Tree, Tree)} over more contrived alternatives. */ | ||
| static final class SuggestedFixSwap { |
There was a problem hiding this comment.
Long-term I guess lexicographical order makes most sense. Here I went with "likelihood of being used".
|
Looks good. No mutations were possible for these changes. |
|
Rebased, will merge once 🟢. |
|
Looks good. No mutations were possible for these changes. |
Suggested commit message:
This PR was written with the aid of GitHub Copilot. It simplifies expressions suggested by Copilot while working on another PR.