Suggestions

PicnicSupermarket · Apr 4, 2023 · cacc84b · cacc84b
1 parent c627149
commit cacc84b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/...r-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/SuggestedFixRules.java b/...r-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/SuggestedFixRules.java
@@ -90,4 +90,17 @@ SuggestedFix after(Tree tree, String postfix) {
       return SuggestedFix.postfixWith(tree, postfix);
     }
   }
+
+  /** Prefer {@link SuggestedFix#delete(Tree)} over more contrived alternatives. */
+  static final class SuggestedFixDelete {
+    @BeforeTemplate
+    SuggestedFix before(Tree tree) {
+      return SuggestedFix.builder().delete(tree).build();
+    }
+
+    @AfterTemplate
+    SuggestedFix after(Tree tree) {
+      return SuggestedFix.delete(tree);
+    }
+  }
 }
diff --git a/...b/src/test/resources/tech/picnic/errorprone/refasterrules/SuggestedFixRulesTestInput.java b/...b/src/test/resources/tech/picnic/errorprone/refasterrules/SuggestedFixRulesTestInput.java
@@ -28,4 +28,8 @@ SuggestedFix testSuggestedFixPrefixWith() {
   SuggestedFix testSuggestedFixPostfixWith() {
     return SuggestedFix.builder().postfixWith(null, "foo").build();
   }
+
+  SuggestedFix testSuggestedFixDelete() {
+    return SuggestedFix.builder().delete((Tree) null).build();
+  }
 }
diff --git a/.../src/test/resources/tech/picnic/errorprone/refasterrules/SuggestedFixRulesTestOutput.java b/.../src/test/resources/tech/picnic/errorprone/refasterrules/SuggestedFixRulesTestOutput.java
@@ -1,5 +1,6 @@
 package tech.picnic.errorprone.refasterrules;
 
+import com.google.errorprone.fixes.SuggestedFix;
 import com.sun.source.tree.ExpressionTree;
 import com.sun.source.tree.Tree;
 import tech.picnic.errorprone.refaster.test.RefasterRuleCollectionTestCase;
@@ -28,4 +29,8 @@ SuggestedFix testSuggestedFixPrefixWith() {
   SuggestedFix testSuggestedFixPostfixWith() {
     return Suggestions.postfixWith(null, "foo");
   }
+
+  SuggestedFix testSuggestedFixDelete() {
+    return SuggestedFix.delete((Tree) null);
+  }
 }