-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Maven API 3.8.7 -> 3.9.5 #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build will fail until GHA uses Maven 3.8.7. There's also the convenience of OSS contributors to consider, so I guess we should not be in a hurry to merge this PR.
Suggested commit message:
Upgrade Maven API 3.8.6 -> 3.8.7 (#434)
See:
- https://maven.apache.org/docs/3.8.7/release-notes.html
- https://github.com/apache/maven/releases/tag/maven-3.8.7
- https://github.com/apache/maven/compare/maven-3.8.6...maven-3.8.7
WDYT of adding |
Makes sense if the Maven version is hardcoded in |
ec5a1c0
to
f0eb3de
Compare
Suggested commit message:
|
Looks good. No mutations were possible for these changes. |
0b5fc26
to
a27cf7f
Compare
Looks good. No mutations were possible for these changes. |
1 similar comment
Looks good. No mutations were possible for these changes. |
a27cf7f
to
0de0896
Compare
Looks good. No mutations were possible for these changes. |
48e3067
to
cdea685
Compare
Looks good. No mutations were possible for these changes. |
8670cb4
to
7e47c82
Compare
Looks good. No mutations were possible for these changes. |
It's 🟢 but maybe we should still wait for a little longer. WDYT? |
Looks good. No mutations were possible for these changes. |
7e47c82
to
89d4c33
Compare
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
Need to leave now, will take a look tomorrow. Need to check out GHA :). |
The issue is that GitHub actions is still on Apache Maven 3.8.8. |
Yeah I was going to check if there were any changes there 😬, but that's probably not the case then. |
584a1ce
to
b5be856
Compare
This PR will get unlocked by #964, though likely we'll want to target Maven 3.9.5, for compatibility with Additionally, we should update the reproducible build spec to build releases with a more recent version of Maven. |
b5be856
to
fd779d6
Compare
Looks good. No mutations were possible for these changes. |
K, I rebased the branch and downgraded to Maven 3.9.5. The release notes also reflect this, so assuming the build passes, I think this one is good to go, @rickie. |
fd779d6
to
f83150f
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There we set the version to 3.9.6 though 🤔.
See: - https://maven.apache.org/release-notes-all.html - https://github.com/apache/maven/releases/tag/maven-3.9.6 - https://github.com/apache/maven/releases/tag/maven-3.9.5 - https://github.com/apache/maven/releases/tag/maven-3.9.4 - https://github.com/apache/maven/releases/tag/maven-3.9.3 - https://github.com/apache/maven/releases/tag/maven-3.9.2 - https://github.com/apache/maven/releases/tag/maven-3.9.1 - https://github.com/apache/maven/releases/tag/maven-3.9.0
f83150f
to
db0bdc9
Compare
Rebased and resolved conflict! |
Looks good. No mutations were possible for these changes. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Yep, because there we don't need |
This PR contains the following updates:
3.8.7
->3.9.6
Release Notes
apache/maven (Maven API)
v3.9.6
: 3.9.6Release Notes - Maven - Version 3.9.6
Improvement
Dependency upgrade
v3.9.5
: 3.9.5Release Notes - Maven - Version 3.9.5
Bug
Improvement
Task
Dependency upgrade
v3.9.4
: 3.9.4Release Notes - Maven - Version 3.9.4
Bug
Dependency upgrade
Full Changelog: apache/maven@maven-3.9.3...maven-3.9.4
v3.9.3
: 3.9.3Release Notes - Maven - Version 3.9.3
Bug
Improvement
Task
Dependency upgrade
v3.9.2
: 3.9.2Release Notes - Maven - Version 3.9.2
Bug
Improvement
Task
Dependency upgrade
v3.9.1
: 3.9.1Release Notes - Maven - Version 3.9.1
Overview About the Changes
Regression fixes from Maven 3.9.0. General performance and other fixes.
Potentially Breaking Core Changes (if migrating from 3.8.x)
The Maven Resolver transport has changed from Wagon to “native HTTP”, see Resolver Transport guide.
Maven 2.x was auto-injecting an ancient version of plexus-utils dependency into the plugin classpath, and Maven 3.x continued doing this to preserve backward compatibility. Starting with Maven 3.9, it does not happen anymore. This change may lead to plugin breakage. The fix for affected plugin maintainers is to explicitly declare a dependency on plexus-utils. The workaround for affected plugin users is to add this dependency to plugin dependencies until issue is fixed by the affected plugin maintainer. See MNG-6965.
Mojos are prevented to boostrap new instance of RepositorySystem (for example by using deprecated ServiceLocator), they should reuse RepositorySystem instance provided by Maven instead. See MNG-7471.
Each line in .mvn/maven.config is now interpreted as a single argument. That is, if the file contains multiple arguments, these must now be placed on separate lines, see MNG-7684.
Bug
Improvement
Task
Dependency upgrade
v3.9.0
: 3.9.0Release Notes - Maven - Version 3.9.0
Sub-task
Bug
New Feature
Improvement
Task
Dependency upgrade