Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven version for Error Prone Support builds #136

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Update Maven version for Error Prone Support builds #136

merged 2 commits into from
Jan 16, 2024

Conversation

Stephan202
Copy link
Contributor

This is in preparation for the upcoming release, which will require a more recent version of Maven.

(I suppose I could have updated only error-prone-support-0.14.0.buildspec, but I updated each *.buildspec to reference the latest Maven version supported.)

@hboutemy
Copy link
Member

it's not really useful to update old recipes: update will be done on next release for the release that requires it

@hboutemy hboutemy closed this Jan 14, 2024
@Stephan202
Copy link
Contributor Author

@hboutemy so you prefer a workflow where the script that picks up releases initially fails? I'm not tracking this project all the time, so it might be a while before I notice. (I assume you're not manually debugging this kind of issue for all projects currently tracked. 🤔)

Not a problem to not merge this PR, but let me try my luck:

  1. WDYT of merging this PR, and I'll promise to only update new releases next time?
  2. Alternatively, WDYT of reducing this PR's scope to just updating the latest release (0.14.0)? I can push a commit for that.

@hboutemy
Copy link
Member

rebuild is done by a human = me, just detection of what to rebuild is automated
I don't want to change all the history of past releases: yes, updating only the latest release is reasonable and will help me not needing to build twice when I discover that prerequisites were updated for the next release

@Stephan202
Copy link
Contributor Author

Ack! I updated the branch to only contain this change:

diff --git a/content/tech/picnic/error-prone-support/error-prone-support/error-prone-support-0.14.0.buildspec b/content/tech/picnic/error-prone-support/error-prone-support/error-prone-support-0.14.0.buildspec
index bfa7befb..a6eeb22b 100644
--- a/content/tech/picnic/error-prone-support/error-prone-support/error-prone-support-0.14.0.buildspec
+++ b/content/tech/picnic/error-prone-support/error-prone-support/error-prone-support-0.14.0.buildspec
@@ -7,7 +7,7 @@ display=${groupId}:${artifactId}
 gitRepo=https://github.com/PicnicSupermarket/${artifactId}.git
 gitTag=v${version}
 
-tool=mvn-3.9.1
+tool=mvn-3.9.6
 jdk=17
 newline=lf
 

@hboutemy hboutemy reopened this Jan 16, 2024
@hboutemy hboutemy merged commit 6845624 into jvm-repo-rebuild:master Jan 16, 2024
@hboutemy
Copy link
Member

thank you

@Stephan202 Stephan202 deleted the sschroevers/error-prone-support branch January 16, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants