Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Maven API 3.9.5 -> 3.9.8 #701

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Upgrade Maven API 3.9.5 -> 3.9.8 #701

merged 2 commits into from
Aug 12, 2024

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Jun 27, 2023 •
edited by Stephan202
Loading

This PR contains the following updates:

Package Type Update Change
Maven API compile patch 3.9.5 -> 3.9.6

Release Notes

apache/maven (Maven API)

v3.9.6: 3.9.6

Release Notes - Maven - Version 3.9.6

Improvement

  • [MNG-7939] - Allow to exclude plugins from validation

Dependency upgrade

  • [MNG-7913] - Upgrade Sisu version to 0.9.0.M2
  • [MNG-7934] - Upgrade Resolver version to 1.9.18
  • [MNG-7942] - Upgrade to parent POM 41
  • [MNG-7943] - Upgrade default plugin bindings
  • If you want to rebase/retry this PR, check this box

@Picnic-Bot Picnic-Bot requested review from rickie and Stephan202 June 27, 2023 01:06
@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Jun 27, 2023 •
edited by Stephan202
Loading

Suggested commit message:

Upgrade Maven API 3.9.5 -> 3.9.8 (#701)

See:
- https://maven.apache.org/release-notes-all.html
- https://github.com/apache/maven/releases/tag/maven-3.9.6
- https://github.com/apache/maven/releases/tag/maven-3.9.7
- https://github.com/apache/maven/releases/tag/maven-3.9.8
- https://github.com/apache/maven/compare/maven-3.9.5...maven-3.9.8

Stephan202
Stephan202 reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the Windows build machines don't have this version yet.

@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch from 5b64347 to ceeaeb9 Compare June 28, 2023 01:23
@rickie
Copy link
Member

rickie commented Jun 28, 2023

As @Badbond mentioned in the internal upgrade PR, we probably also want to wait for the support in mvnd. This is the most recent milestone that will update it to 3.9.1: https://github.com/apache/maven-mvnd/releases/tag/1.0-m6.

@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch from ceeaeb9 to 2cb16cb Compare June 29, 2023 01:05
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie
Copy link
Member

rickie commented Jun 29, 2023

I'll add the pause renovate :).

@rickie rickie added pause renovate Stop automatic rebasing blocked This blocks either a release or a downstream project labels Jun 29, 2023
@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch from 2cb16cb to 25bc4c2 Compare August 14, 2023 11:33
@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch from 25bc4c2 to d4189b4 Compare August 26, 2023 11:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch from d4189b4 to 0acef54 Compare December 26, 2023 18:13
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 removed blocked This blocks either a release or a downstream project pause renovate Stop automatic rebasing labels Jan 12, 2024
@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch from 0acef54 to ac03e15 Compare January 12, 2024 20:30
@Stephan202
Copy link
Member

So the Windows build machines don't have this version yet.

This is still the case. #964 should provide a solution, after which we can merge #434.

@Stephan202 Stephan202 added the pause renovate Stop automatic rebasing label Jan 12, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the renovate/patch-version.maven branch from ac03e15 to 4e8593b Compare January 13, 2024 20:32
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 removed the pause renovate Stop automatic rebasing label Jan 30, 2024
@Stephan202
Copy link
Member

Stephan202 commented Jan 30, 2024 •
edited
Loading

We merged #434 instead; Renovate should close this PR tomorrow. Nope, there's of course still version 3.9.6, which we're not adopting until mvnd supports it.

@Picnic-Bot Picnic-Bot changed the title Upgrade Maven API 3.8.7 -> 3.8.8 Upgrade Maven API 3.9.5 -> 3.9.6 Jan 31, 2024
@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch 3 times, most recently from 2445b00 to df57e53 Compare February 2, 2024 02:09
@rickie rickie added the pause renovate Stop automatic rebasing label Feb 2, 2024
@Stephan202 Stephan202 force-pushed the renovate/patch-version.maven branch from df57e53 to 39aab4c Compare February 11, 2024 15:19
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Picnic-Bot Picnic-Bot force-pushed the renovate/patch-version.maven branch from 39aab4c to 8145604 Compare February 11, 2024 16:00
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Stephan202 Stephan202 removed the pause renovate Stop automatic rebasing label Aug 4, 2024
@Stephan202 Stephan202 force-pushed the renovate/patch-version.maven branch from 8145604 to deb492f Compare August 5, 2024 05:55
@Stephan202 Stephan202 changed the title Upgrade Maven API 3.9.5 -> 3.9.6 Upgrade Maven API 3.9.5 -> 3.9.8 Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the renovate/patch-version.maven branch from deb492f to 776cdcb Compare August 12, 2024 09:25
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Stephan202 Stephan202 added this to the 0.19.0 milestone Aug 12, 2024
Stephan202
Stephan202 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickie I just realized that the build failed because we explicitly used an older version of Maven. PR is now ready for review!

@rickie rickie merged commit 552ddf6 into master Aug 12, 2024
16 checks passed
@rickie rickie deleted the renovate/patch-version.maven branch August 12, 2024 14:14
mohamedsamehsalah pushed a commit that referenced this pull request Aug 18, 2024
@Picnic-Bot @mohamedsamehsalah
Upgrade Maven API 3.9.5 -> 3.9.8 (#701)
dad3f5d 
See:
- https://maven.apache.org/release-notes-all.html
- https://github.com/apache/maven/releases/tag/maven-3.9.6
- https://github.com/apache/maven/releases/tag/maven-3.9.7
- https://github.com/apache/maven/releases/tag/maven-3.9.8
- apache/maven@maven-3.9.5...maven-3.9.8
mohamedsamehsalah pushed a commit that referenced this pull request Aug 18, 2024
@Picnic-Bot @mohamedsamehsalah
Upgrade Maven API 3.9.5 -> 3.9.8 (#701)
4fdd24f 
See:
- https://maven.apache.org/release-notes-all.html
- https://github.com/apache/maven/releases/tag/maven-3.9.6
- https://github.com/apache/maven/releases/tag/maven-3.9.7
- https://github.com/apache/maven/releases/tag/maven-3.9.8
- apache/maven@maven-3.9.5...maven-3.9.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
dependencies
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Picnic-Bot @rickie @Stephan202