Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deeper dynamic pages #4

Closed
g105b opened this issue Aug 29, 2021 · 4 comments · Fixed by #14
Closed

Deeper dynamic pages #4

g105b opened this issue Aug 29, 2021 · 4 comments · Fixed by #14
Assignees
@g105b
Labels
enhancement New feature or request

Comments

@g105b
Copy link
Member

g105b commented Aug 29, 2021 •
edited
Loading

If the matching view/logic files have a dynamic leaf (deepest filename starts with "@"), requests to deeper directories that don't exist still trigger the leaf logic/view.

This might be expected - how else could a deep directory be built? Maybe this needs to be handled separately by a special file - page/@dynamicDir/_deeper.php for instance?

Logic is now changed...
@g105b g105b self-assigned this Oct 8, 2021
@g105b
Copy link
Member Author

g105b commented Oct 8, 2021

The logic has now been changed so with a directory structure of: /page/shop/@category/@item.php, a request to /shop/phone/apple/iphone/12 doesn't match the @item.php page any more, so will in turn throw a 404.

I'm keeping this issue open to track an improvement, which is to be able to serve deeper page requests from individual files. An idea of how to indicate that a dynamic page should serve any matching deeper request would be to convert the filename to @@item.php. This could also apply to directory names, but I'll have to think about the knock on effects of this.

@g105b g105b added the enhancement New feature or request label Oct 17, 2021
@g105b
Copy link
Member Author

g105b commented Oct 17, 2021

Ties in with #5 nicely

@g105b
Copy link
Member Author

g105b commented Nov 3, 2021

The @@ syntax is nice, but I'm not going to implement it before v4, as stable release is a priority.

@g105b
Copy link
Member Author

g105b commented Feb 20, 2022

v4 has been released. Planning on working on this soon.

g105b added a commit that referenced this issue Feb 21, 2022
@g105b
feature: deeper dynamic pages
37bff72 
closes #4
This was referenced Feb 21, 2022
Merged
Closed
@g105b g105b closed this as completed in #14 Feb 21, 2022
g105b added a commit that referenced this issue Feb 21, 2022
@g105b
feature: deeper dynamic pages
00c0f69 
closes #4
g105b added a commit that referenced this issue Sep 6, 2022
@g105b
Dependabot (#22)
1c74660 
* feature: deeper dynamic pages
closes #4

* maintenance: dependabot
closes #21
g105b added a commit that referenced this issue Jan 17, 2023
@g105b
Star accept header (*/*) matches the first route (#30)
e00c1e0 
* feature: deeper dynamic pages
closes #4

* feature: test matching star accept header
closes #19
g105b added a commit that referenced this issue Jul 20, 2023
@g105b
Update build deps and PHPStorm analysis tweaks (#53)
3390be9 
* feature: deeper dynamic pages
closes #4

* build: upgrade build packages for downstream deps

* tweak: phpstorm analysis

* test: remove scrutinizer

* test: move phpunit config

* test: upgrade phpunit

* ci: upgrade ci config
g105b added a commit that referenced this issue Oct 19, 2023
@g105b
Fix for dynamic sibling files (#56)
131946a 
* feature: deeper dynamic pages
closes #4

* build: upgrade build packages for downstream deps

* tweak: phpstorm analysis

* wip: isolate and work on #55

* fix: fix logic comparing sibling files
closes #55
g105b added a commit that referenced this issue Oct 24, 2023
@g105b
Nested dynamic sibling (#60)
5ed50f3 
* feature: deeper dynamic pages
closes #4

* build: upgrade build packages for downstream deps

* tweak: phpstorm analysis

* fix: FileMatch matches nested dynamic siblings
closes #59
g105b added a commit that referenced this issue Oct 24, 2023
@g105b
Distinct files are allowed to start with underscore (#58)
9304e14 
* feature: deeper dynamic pages
closes #4

* build: upgrade build packages for downstream deps

* tweak: phpstorm analysis

* test: isolate issue #57

* feature: allow underscore files
closes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: deeper dynamic pages PhpGt/Routing
1 participant
@g105b