Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic path - get() without parameter #5

Closed
g105b opened this issue Oct 1, 2021 · 1 comment · Fixed by #6
Closed

Dynamic path - get() without parameter #5

g105b opened this issue Oct 1, 2021 · 1 comment · Fixed by #6
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@g105b
Copy link
Member

g105b commented Oct 1, 2021

If the $dyanmicPath->get() function is called without a parameter, and there is only one dynamic part to the path, it should return it.

If there is more than one part of the path that's dynamic, and an identifier hasn't been supplied, throw an exception.
@g105b g105b added enhancement New feature or request good first issue Good for newcomers labels Oct 1, 2021
@g105b g105b mentioned this issue Oct 17, 2021
Closed
@g105b
Copy link
Member Author

g105b commented Oct 17, 2021

Rather than throwing an exception, it might be more useful to just return the deepest dynamic path variable.

g105b added a commit that referenced this issue Nov 3, 2021
@g105b
feature: dynamic path without a get parameter returns deepest dynamic…
83053cf 
… match

closes #5
@g105b g105b mentioned this issue Nov 3, 2021
Merged
@g105b g105b closed this as completed in #6 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: dynamic path without a get parameter returns deepest dynamic match PhpGt/Routing
1 participant
@g105b