Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching */* is not explicit #19

Closed
g105b opened this issue Jun 19, 2022 · 0 comments · Fixed by #30
Closed

Matching */* is not explicit #19

g105b opened this issue Jun 19, 2022 · 0 comments · Fixed by #30

Comments

@g105b
Copy link
Member

g105b commented Jun 19, 2022 •
edited
Loading

The */* match is inferred for any non-matches. This means that whatever match comes at the end of the class (in order of the functions' declarations) is always preferred for a user agent that requests */* accept header.

The expected functionality is to match a route only if the */* is present in the available header matches.
g105b added a commit that referenced this issue Jan 17, 2023
@g105b
feature: test matching star accept header
e7a003f 
closes #19
@g105b g105b mentioned this issue Jan 17, 2023
Merged
@g105b g105b closed this as completed in #30 Jan 17, 2023
g105b added a commit that referenced this issue Jan 17, 2023
@g105b
Star accept header (*/*) matches the first route (#30)
e00c1e0 
* feature: deeper dynamic pages
closes #4

* feature: test matching star accept header
closes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Star accept header (*/*) matches the first route PhpGt/Routing
1 participant
@g105b