Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search files] fix preview for files with spaces (again) #152

Merged
merged 5 commits into from
Apr 18, 2021

Conversation

PatrickF1
Copy link
Owner

Apparently, I didn't actually fix this bug when I tried to fix it in #137

@PatrickF1
Copy link
Owner Author

PatrickF1 commented Apr 15, 2021

@kidonng Ok this fixes bug 1 from #137 but it introduces a new bug, which I shall call bug 3. To repro

  1. mkdir -p "normal/with spaces"
  2. touch "normal/with spaces"/{1,2,3}
  3. execute search directory with cursor on normal/
  4. Notice you can't preview the files in normal

I realized both of these bugs actually weren't a problem until #137, so I must have broke something trying to fix something else. So confused...this is what I was afraid of when introducing all of these features to search directory. Never mind going back to the commit before #137, I was able to repro bug 1 but not bug 3.

@PatrickF1 PatrickF1 force-pushed the fix-file-space-preview-again branch from 2689c14 to b8579d9 Compare April 16, 2021 00:08
@PatrickF1 PatrickF1 force-pushed the fix-file-space-preview-again branch from b8579d9 to 51774cd Compare April 16, 2021 00:16
@PatrickF1 PatrickF1 merged commit 4ba889a into main Apr 18, 2021
@PatrickF1 PatrickF1 deleted the fix-file-space-preview-again branch April 18, 2021 15:50
@kidonng
Copy link
Contributor

kidonng commented Apr 20, 2021

(Sigh) We could have settled on this from the beginning. Thanks for the fix!

@PatrickF1
Copy link
Owner Author

Yeah, that was my bad. I should have investigated closer. I've been pretty demotivated about maintaining this feature. It's been quite a thorn in my side siphoning my time for other feature I'd rather work on.

hrshtst pushed a commit to hrshtst/fzf.fish that referenced this pull request Apr 26, 2021
Apparently, I didn't actually fix this bug when I tried to fix it in PatrickF1#137.
@kidonng
Copy link
Contributor

kidonng commented May 12, 2021

I don't want to see you feeling bad about all these issues, but I have to say this issue (Bug 2 in #137 (comment)) is still no fixed.

To reproduce, set $fzf_preview_dir_cmd and search with a base directory with spaces in its name:

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants