-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search files] fix preview for files with spaces (again) #152
Conversation
@kidonng Ok this fixes bug 1 from #137 but it introduces a new bug, which I shall call bug 3. To repro
|
2689c14
to
b8579d9
Compare
b8579d9
to
51774cd
Compare
(Sigh) We could have settled on this from the beginning. Thanks for the fix! |
Yeah, that was my bad. I should have investigated closer. I've been pretty demotivated about maintaining this feature. It's been quite a thorn in my side siphoning my time for other feature I'd rather work on. |
Apparently, I didn't actually fix this bug when I tried to fix it in PatrickF1#137.
I don't want to see you feeling bad about all these issues, but I have to say this issue (Bug 2 in #137 (comment)) is still no fixed. To reproduce, set |
Apparently, I didn't actually fix this bug when I tried to fix it in #137