[Search directory] fix preview when base dir contains spaces (patch 3)

[kidonng]

There is still, yet another bug, afflicting the search directory feature. To reproduce, set -x fzf_preview_dir_cmd ls and search with a base directory with spaces in its name:

As it turned out, escaping quotes isn't a good idea either. The correct way to use eval is to quote the code entirely. Single quotes for parameter is used for programs instead.

This is a followup from #137 and #152

[PatrickF1]

Can you explain why this?

As it turned out, escaping quotes isn't a good idea either. The correct way to use eval is to quote the code entirely.

[PatrickF1]

@kidonng ^ bump on my question

[kidonng]

Honestly, I don't know either. Maybe I will search for related docs or experiment a bit and give a better answer later, but I think you can merge it first if you like it.

[kidonng]

Can you explain why this?

As it turned out, escaping quotes isn't a good idea either. The correct way to use eval is to quote the code entirely.

I think the answer is the same as before: we need to quote the path and we need to quote it right. Simply escaping the quotes may looks right but in fact isn't, the eval still sees it unquoted.

[PatrickF1]

Simply escaping the quotes may looks right but in fact isn't, the eval still sees it unquoted.

Ah that makes sense.