Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search directory] fix previewing symlinks containing spaces #164

Merged
merged 1 commit into from
May 28, 2021
Merged

[Search directory] fix previewing symlinks containing spaces #164

merged 1 commit into from
May 28, 2021

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented May 20, 2021

Due to #152, this is broken while all other $file_path references have been correctly quoted.

image

PatrickF1
PatrickF1 approved these changes May 28, 2021
View reviewed changes
Copy link
Owner

@PatrickF1 PatrickF1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Sorry for the delay.

@PatrickF1 PatrickF1 changed the title [Search directory] quote realpath's argument [Search directory] fix previewing symlinks containing spaces May 28, 2021
@PatrickF1 PatrickF1 merged commit c1669c2 into PatrickF1:main May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickF1 PatrickF1 PatrickF1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidonng @PatrickF1