fix(gitlab): add proper client-side alias handling #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c/parabol into fix/6033/gitlab-alias-projects
|
gonna merge this in just to keep the PR review going along... |
mattkrick
added a commit
that referenced
this pull request
Apr 19, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * clean-up return statement in fetchGitLabProjects * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query Co-authored-by: Matt Krick <[email protected]>
mattkrick
added a commit
that referenced
this pull request
Apr 19, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query * feat(sprint-poker): Filter GitLab issues by project (#6323) * query projects from project filter menu * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * remove alias * make selectedProjectIds nullable * remove useLoadNextOnScrollBottom and increase default projects first * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * remove gitlab types * add viewerMeetingMember check and remove selectedProjectsIds resolver * make selectedProjectsIds null if empty array Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Matt Krick <[email protected]>
nickoferrall
added a commit
that referenced
this pull request
Apr 19, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * remove refetchable from gitlab scoping results query * make selectedProjectsIds null if empty array * use optional chaining rather than destructuring many vars * feat(sprint-poker): GitLab issue is visible in Estimate phase (#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * use join method in currentFilters Co-authored-by: Matt Krick <[email protected]>
JimmyLv
pushed a commit
that referenced
this pull request
Apr 19, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * clean-up return statement in fetchGitLabProjects * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query Co-authored-by: Matt Krick <[email protected]>
JimmyLv
pushed a commit
that referenced
this pull request
Apr 19, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query * feat(sprint-poker): Filter GitLab issues by project (#6323) * query projects from project filter menu * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * remove alias * make selectedProjectIds nullable * remove useLoadNextOnScrollBottom and increase default projects first * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * remove gitlab types * add viewerMeetingMember check and remove selectedProjectsIds resolver * make selectedProjectsIds null if empty array Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Matt Krick <[email protected]>
JimmyLv
pushed a commit
that referenced
this pull request
Apr 19, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * remove refetchable from gitlab scoping results query * make selectedProjectsIds null if empty array * use optional chaining rather than destructuring many vars * feat(sprint-poker): GitLab issue is visible in Estimate phase (#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * use join method in currentFilters Co-authored-by: Matt Krick <[email protected]>
nickoferrall
added a commit
that referenced
this pull request
Apr 20, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * track start of search * track end of search * track updated poker scope * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * track selected gitlab project filter * track selected all issues * track cleared gitlab search * remove refetchable from gitlab scoping results query * fix ts error * keep focus in search input after clearing query * change searchQueryFilters event track options from string to id * use nullish coalescing instead of logical or * make selectedProjectsIds null if empty array * update SegmentEventTrackOptions * use optional chaining rather than destructuring many vars * feat(sprint-poker): GitLab issue is visible in Estimate phase (#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * update event titles and include service * capitalise search in event tracking Co-authored-by: Matt Krick <[email protected]>
atannus
pushed a commit
to atannus/parabol
that referenced
this pull request
Apr 26, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * clean-up return statement in fetchGitLabProjects * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (ParabolInc#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query Co-authored-by: Matt Krick <[email protected]>
atannus
pushed a commit
to atannus/parabol
that referenced
this pull request
Apr 26, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (ParabolInc#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query * feat(sprint-poker): Filter GitLab issues by project (ParabolInc#6323) * query projects from project filter menu * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * remove alias * make selectedProjectIds nullable * remove useLoadNextOnScrollBottom and increase default projects first * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * remove gitlab types * add viewerMeetingMember check and remove selectedProjectsIds resolver * make selectedProjectsIds null if empty array Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Matt Krick <[email protected]>
atannus
pushed a commit
to atannus/parabol
that referenced
this pull request
Apr 26, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * fix(gitlab): add proper client-side alias handling (ParabolInc#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * remove refetchable from gitlab scoping results query * make selectedProjectsIds null if empty array * use optional chaining rather than destructuring many vars * feat(sprint-poker): GitLab issue is visible in Estimate phase (ParabolInc#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * use join method in currentFilters Co-authored-by: Matt Krick <[email protected]>
atannus
pushed a commit
to atannus/parabol
that referenced
this pull request
Apr 26, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * track start of search * track end of search * track updated poker scope * fix(gitlab): add proper client-side alias handling (ParabolInc#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * track selected gitlab project filter * track selected all issues * track cleared gitlab search * remove refetchable from gitlab scoping results query * fix ts error * keep focus in search input after clearing query * change searchQueryFilters event track options from string to id * use nullish coalescing instead of logical or * make selectedProjectsIds null if empty array * update SegmentEventTrackOptions * use optional chaining rather than destructuring many vars * feat(sprint-poker): GitLab issue is visible in Estimate phase (ParabolInc#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * update event titles and include service * capitalise search in event tracking Co-authored-by: Matt Krick <[email protected]>
Dschoordsch
pushed a commit
that referenced
this pull request
May 4, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * remove refetchable from gitlab scoping results query * make selectedProjectsIds null if empty array * use optional chaining rather than destructuring many vars * feat(sprint-poker): GitLab issue is visible in Estimate phase (#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * Make abstract versions of some poker scope search components * Filter button * Jira Server filter menu * current filters * JQL and projects filter * Remove console log * Tweak code style * JiraScopingSearchHistoryToggle * JiraScopingSearchInput * Change ariaLabel * Fix types * Tweak variables * Tweak code style * Validate search string Co-authored-by: Nick O'Ferrall <[email protected]> Co-authored-by: Matt Krick <[email protected]>
nickoferrall
added a commit
that referenced
this pull request
May 4, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * track start of search * track end of search * track updated poker scope * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * track selected gitlab project filter * track selected all issues * track cleared gitlab search * remove refetchable from gitlab scoping results query * fix ts error * keep focus in search input after clearing query * change searchQueryFilters event track options from string to id * use nullish coalescing instead of logical or * make selectedProjectsIds null if empty array * update SegmentEventTrackOptions * render gitlab menu ui * implement gitlab dimension query and mutation * use optional chaining rather than destructuring many vars * use gid instead of project path in gitlab dimension queries * begin implementing pushEstimateToGitLab * feat(sprint-poker): GitLab issue is visible in Estimate phase (#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * able to push comment to gitlab issue * fix linting errors * change mutation name to createNote * remove log * update types in pushEstimateToGitLab * update pushEstimateToGitLab checks * use new sdl pattern in updateGitLabDimensionField * change teamId to varchar(100) * use projectId and providerId in gitlab dimension queries * use GetIssueQuery type * return success payload for updateGitlabDimensionField mutation * use accessUserId instead of viewerId for the gitlabAuth Co-authored-by: Matt Krick <[email protected]>
nickoferrall
added a commit
that referenced
this pull request
May 4, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * track start of search * track end of search * track updated poker scope * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * track selected gitlab project filter * track selected all issues * track cleared gitlab search * remove refetchable from gitlab scoping results query * fix ts error * keep focus in search input after clearing query * change searchQueryFilters event track options from string to id * use nullish coalescing instead of logical or * make selectedProjectsIds null if empty array * update SegmentEventTrackOptions * render gitlab menu ui * implement gitlab dimension query and mutation * use optional chaining rather than destructuring many vars * use gid instead of project path in gitlab dimension queries * begin implementing pushEstimateToGitLab * feat(sprint-poker): GitLab issue is visible in Estimate phase (#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * able to push comment to gitlab issue * fix linting errors * change mutation name to createNote * remove log * implement gitlab TaskIntegrationManager in GitLabServerManager and refactor createGitLabTask to use the createIssue method * implement createNote method * implement getProjects in GitLabServerManager * implement create task in GitLabServerManager * update types in pushEstimateToGitLab * can push a task to gitlab * after integrating a task with gitlab, the task ui updates * update pushEstimateToGitLab checks * add provider check * implement AddToGitLabMenuItem * use new sdl pattern in updateGitLabDimensionField * remove redundant auth check * change teamId to varchar(100) * use projectId and providerId in gitlab dimension queries * use GetIssueQuery type * check if gitlab exists as it doesnt in the demo * use integrationsRef instead of gitlab ref * return success payload for updateGitlabDimensionField mutation * use accessUserId instead of viewerId for the gitlabAuth * implement addCreatedBySomeoneElseComment Co-authored-by: Matt Krick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that problem where fullPath was required on the client side.
adding fullPath to the client didn't actually fix the problem, it just masked it.
full loom here: https://www.loom.com/share/79e4d705572c40bdba449b12bc3250b7