feat(sprint-poker): Search GitLab issues #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rabolInc/parabol into feat/6088/gitlab-issues-functionality
* resolve to aliased fields * resolve to aliased fields
|
LGTM, i'll move this to stuck until the base PR gets merged |
* query projects from project filter menu * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * remove alias * make selectedProjectIds nullable * remove useLoadNextOnScrollBottom and increase default projects first * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * remove gitlab types * add viewerMeetingMember check and remove selectedProjectsIds resolver * make selectedProjectsIds null if empty array Co-authored-by: Matt Krick <[email protected]>
JimmyLv
pushed a commit
that referenced
this pull request
Apr 19, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query * feat(sprint-poker): Filter GitLab issues by project (#6323) * query projects from project filter menu * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * remove alias * make selectedProjectIds nullable * remove useLoadNextOnScrollBottom and increase default projects first * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * remove gitlab types * add viewerMeetingMember check and remove selectedProjectsIds resolver * make selectedProjectsIds null if empty array Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Matt Krick <[email protected]>
atannus
pushed a commit
to atannus/parabol
that referenced
this pull request
Apr 26, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * merge with master * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * fix(gitlab): add proper client-side alias handling (ParabolInc#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * remove refetchable from gitlab scoping results query * feat(sprint-poker): Filter GitLab issues by project (ParabolInc#6323) * query projects from project filter menu * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * remove alias * make selectedProjectIds nullable * remove useLoadNextOnScrollBottom and increase default projects first * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * remove gitlab types * add viewerMeetingMember check and remove selectedProjectsIds resolver * make selectedProjectsIds null if empty array Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Matt Krick <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6045
To test
gitlabfeature flag. If that doesn't work, runyarn postdeployto make sure thecloudProvideris addedNote: with GitLab's search API, no results are returned if the search term doesn't match the issue title. So, if an issue is called Test and you type in "Tes", the issue may not show up.