feat(sprint-poker): Track GitLab events #6367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rabolInc/parabol into feat/6088/gitlab-issues-functionality
nickoferrall
requested review from
Dschoordsch
and removed request for
mattkrick
* refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent
Base automatically changed from
feat/6244/gitlab-visible-in-estimate
to
feat/6138/new-scope-search-ui
April 12, 2022 15:58
nickoferrall
changed the base branch from
feat/6138/new-scope-search-ui
to
master
nickoferrall
changed the base branch from
master
to
feat/6138/new-scope-search-ui
…/parabol into feat/6138/new-scope-search-ui
Dschoordsch
requested changes
Apr 19, 2022
Dschoordsch
requested changes
Apr 20, 2022
Dschoordsch
approved these changes
Apr 20, 2022
|
|
||
| const onChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| const {value} = e.target | ||
| if (!queryString) { | ||
| trackEvent('Started Poker Scope search') |
There was a problem hiding this comment.
+1 Not a big deal, but the random capitalization seems odd to me as it is inconsistent with 'Selected Poker Scope Project Filter'. Seeing the existing events, these also seem to have random capital letters.
There was a problem hiding this comment.
True, I've capitalised search to make it more consistent
atannus
pushed a commit
to atannus/parabol
that referenced
this pull request
Apr 26, 2022
* render list of gitlab issues * use usePaginationFragment * increase default value for usePaginationFragment * implement GitLabScopingSearchResultItem * add GitLabScopingSelectAllIssues * can add and remove gitlab issues in scope phase * add UpdatePokerScopeMutation gitlab optimistic updater * able to select all issues * clean up type errors * add projects name alias to rootSchema * include projectIds in search query * return iid from GitLabIssueId * sort projects by lastActivityAt * implement fetchGitLabProjects * implement gitlab issue menu * implement NewGitLabIssueMenuRoot instead of using useAllIntegrations * load next if projects dont have any issues * update comment * remove gitlab menu root and use defaultProjects query to populate menu * increase projectsFirst from 10 to 20 * query all gitlab projects * chore(comment): how to extend BaseTaskIntegration * able to create a new gitlab issue * use GitLabServerManager and implement parseWebPath * fix undefined baseUri * changed taskIntegrationGitLab and GitLabId to use providerId * lowercase gitlabRequest to be consistent with gh * add handle create gitlab issue * add info fragment and return data instead of data.issue * add serverBaseUrl * adjusted root schema and can now render projects in input menu again * clean up update poker scope and create task gitlab * fix ts errors * add gitlab query types * add fullPath to gitLab issue edge if exists * get nodes appearing on insert * get gitlab issue title in create task updater * include webUrl in createTask query so user can click on newly create issue url * add first and sort to allProjects query * rename GitLabRepo to GitLabProject * pass meetingId to issue input rather than querying it * add gitlab search query * filter by gitlab search query * refactor to hooks * query projects from project filter menu * remove __typename and resolveTypes * update UpdatePokerScopeMutation to fix selectAll bug * render projects in filter menu * use fullPath in gitlab menu and adjust max width * refactor gitlab search query from string to object with projectIds * selecting a project in the filter menu adds the item to selectedProjectsFullPath * selecting a project filters the results * add search icon * add search icon * remove searchQuery from scoping results query * clean-up return statement in fetchGitLabProjects * remove alias * make selectedProjectIds nullable * add search to issue args * include search string when adding new gitlab issue * refactor search query to a gql object * remove useLoadNextOnScrollBottom and increase default projects first * merge with master * fix selectedProjects type err * add search string to differentiate project menu query and include ids in project connection so we can add issues with a filter * use react-swipeable-views workaround * add _xGitLabProject resolver * merge with master * remove resolverTypes and gitlabTypes * map over tabs instead of contents * implement new scope search ui in gitlab * refactor gitlabSearchQuery from selectedProjectsIds to selectedProjects * selected projects showing up in current filters * truncate current filters * add new scope search to jira * show jira project names * improve current filters positioning * remove gitlab types * implement new scope search ui in parabol integration * implement new scope search bar ui in github * change filter var to status * query projects from GitLabIntegration and remove fullPath from gitlab search query * refactor scoping results query to usePagination and add alias to new issue query so it is not affected by parent query filtering * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * track start of search * track end of search * track updated poker scope * fix(gitlab): add proper client-side alias handling (ParabolInc#6361) * resolve to aliased fields * resolve to aliased fields * make poker input menu a dropdown and fix width * refactor baseTabs to include Component * create a single source of truth for gitlab issue args * add viewerMeetingMember check and remove selectedProjectsIds resolver * track selected gitlab project filter * track selected all issues * track cleared gitlab search * remove refetchable from gitlab scoping results query * fix ts error * keep focus in search input after clearing query * change searchQueryFilters event track options from string to id * use nullish coalescing instead of logical or * make selectedProjectsIds null if empty array * update SegmentEventTrackOptions * use optional chaining rather than destructuring many vars * feat(sprint-poker): GitLab issue is visible in Estimate phase (ParabolInc#6355) * refactor PokerEstimateHeaderCard to make PokerEstimateHeaderCardContent reusable * adding commit to play by the gh title rules * use nullish coalescing instead of logical or * spread headerFields into PokerEstimateHeaderCardContent * update event titles and include service * capitalise search in event tracking Co-authored-by: Matt Krick <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6303
To test:
SEGMENT_WRITE_KEYandSEGMENT_FN_KEYfrom the production env vars in the devops repo. Paste them in your.envfileviewerId. Select on the user and see the GitLab eventsThis PR adds event tracking in GitLab to the following:
This PR tracks when a project has been created: #6332