Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flat bedrock world config #9728

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Sep 15, 2023

Fixes #8954

Takes advantage of modifying default vanilla resource files to change all the bedrock roof/floors to a custom condition source that accounts for the world config.

Supersedes #8955


Download the paperclip jar for this pull request: paper-9728.zip

@Machine-Maker Machine-Maker requested a review from a team as a code owner September 15, 2023 19:25
Copy link
Member

@electronicboy electronicboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test on current hardware, but, looking over this looks fine to me

@SO-32
Copy link

SO-32 commented Oct 4, 2023

Tested PR. Changed configs as showed in issue. Bedrock generation in new world is flat.

@Warriorrrr Warriorrrr added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Oct 5, 2023
@Machine-Maker Machine-Maker merged commit 7e5dd92 into PaperMC:master Oct 10, 2023
1 check passed
@Machine-Maker Machine-Maker deleted the fix/flat-bedrock branch October 10, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Paper 1.19.3 generate-flat-bedrock function broken
5 participants