Fix flat bedrock setting #8955
Closed
Fix flat bedrock setting #8955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
added
the
status: blocked
|
Requires PaperMC/paperweight#190 to be properly fixed |
Warriorrrr
removed
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I decided to go ahead and do this anyway, if only to demonstrate that this should NOT be the fix we decide to go with. This fix does work, and will only affect noise settings files for the
overworldandnetherfrom the built-in datapack, but it'd be much easier to change 1 line in each of the 5 json files inside the jar instead.